Re: [PATCH v2 15/16] clk: Detect failure to set defaults

2021-10-24 Thread Simon Glass
Hi, On Wed, 20 Oct 2021 at 01:17, Rasmus Villemoes wrote: > > On 20/08/2021 20.18, Simon Glass wrote: > > Hi Harm, > > > > On Wed, 18 Aug 2021 at 08:09, Harm Berntsen wrote: > >> > >> On Thu, 2021-05-13 at 19:39 -0600, Simon Glass wrote: > >>> int clk_uclass_post_probe(struct udevice *dev) >

Re: [PATCH v2 15/16] clk: Detect failure to set defaults

2021-10-20 Thread Rasmus Villemoes
On 20/08/2021 20.18, Simon Glass wrote: > Hi Harm, > > On Wed, 18 Aug 2021 at 08:09, Harm Berntsen wrote: >> >> On Thu, 2021-05-13 at 19:39 -0600, Simon Glass wrote: >>> int clk_uclass_post_probe(struct udevice *dev) >>> { >>> + int ret; >>> + >>> /* >>> * when a clock

Fwd: Re: [PATCH v2 15/16] clk: Detect failure to set defaults

2021-08-26 Thread Harm Berntsen
15/16] clk: Detect failure to set defaults Date: Fri, 20 Aug 2021 12:18:07 -0600 > Hi Harm, > > On Wed, 18 Aug 2021 at 08:09, Harm Berntsen > wrote: > > > > On Thu, 2021-05-13 at 19:39 -0600, Simon Glass wrote: > > > When the default clocks cannot be set, t

Re: [PATCH v2 15/16] clk: Detect failure to set defaults

2021-08-20 Thread Simon Glass
Hi Harm, On Wed, 18 Aug 2021 at 08:09, Harm Berntsen wrote: > > On Thu, 2021-05-13 at 19:39 -0600, Simon Glass wrote: > > When the default clocks cannot be set, the clock is silently probed and > > the error is ignored. This is incorrect, since having the clocks at the > > correct speed may be

Re: [PATCH v2 15/16] clk: Detect failure to set defaults

2021-08-18 Thread Harm Berntsen
On Thu, 2021-05-13 at 19:39 -0600, Simon Glass wrote: > When the default clocks cannot be set, the clock is silently probed and > the error is ignored. This is incorrect, since having the clocks at the > correct speed may be important for operation of the system. > > Fix it by checking the return

Re: [PATCH v2 15/16] clk: Detect failure to set defaults

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:31PM -0600, Simon Glass wrote: > When the default clocks cannot be set, the clock is silently probed and > the error is ignored. This is incorrect, since having the clocks at the > correct speed may be important for operation of the system. > > Fix it by checking

[PATCH v2 15/16] clk: Detect failure to set defaults

2021-05-13 Thread Simon Glass
When the default clocks cannot be set, the clock is silently probed and the error is ignored. This is incorrect, since having the clocks at the correct speed may be important for operation of the system. Fix it by checking the return code. Signed-off-by: Simon Glass --- (no changes since v1)