Re: [PATCH v2 16/19] i2c: kona_i2c: Update to use standard enums for speed

[Heiko Schocher]

Hello simon,

Am 03.01.2020 um 23:26 schrieb Simon Glass:

Update this driver to use the new standard enums for speed.

Note: This driver needs to move to driver model.

Signed-off-by: Simon Glass 
---

Changes in v2: None

  drivers/i2c/kona_i2c.c | 28 +++-
  1 file changed, 11 insertions(+), 17 deletions(-)


Reviewed-by: Heiko Schocher 

bye,
Heiko
--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de

[PATCH v2 16/19] i2c: kona_i2c: Update to use standard enums for speed

[Simon Glass]

Update this driver to use the new standard enums for speed.

Note: This driver needs to move to driver model.

Signed-off-by: Simon Glass 
---

Changes in v2: None

 drivers/i2c/kona_i2c.c | 28 +++-
 1 file changed, 11 insertions(+), 17 deletions(-)

diff --git a/drivers/i2c/kona_i2c.c b/drivers/i2c/kona_i2c.c
index d13e4deee5..0726b4c956 100644
--- a/drivers/i2c/kona_i2c.c
+++ b/drivers/i2c/kona_i2c.c
@@ -98,12 +98,6 @@ enum bcm_kona_cmd_t {
BCM_CMD_STOP,
 };
 
-enum bus_speed_index {
-   BCM_SPD_100K = 0,
-   BCM_SPD_400K,
-   BCM_SPD_1MHZ,
-};
-
 /* Internal divider settings for standard mode, fast mode and fast mode plus */
 struct bus_speed_cfg {
uint8_t time_m; /* Number of cycles for setup time */
@@ -115,9 +109,9 @@ struct bus_speed_cfg {
 };
 
 static const struct bus_speed_cfg std_cfg_table[] = {
-   [BCM_SPD_100K] = {0x01, 0x01, 0x03, 0x06, 0x00, 0x02},
-   [BCM_SPD_400K] = {0x05, 0x01, 0x03, 0x05, 0x01, 0x02},
-   [BCM_SPD_1MHZ] = {0x01, 0x01, 0x03, 0x01, 0x01, 0x03},
+   [IC_SPEED_MODE_STANDARD] = {0x01, 0x01, 0x03, 0x06, 0x00, 0x02},
+   [IC_SPEED_MODE_FAST] = {0x05, 0x01, 0x03, 0x05, 0x01, 0x02},
+   [IC_SPEED_MODE_FAST_PLUS] = {0x01, 0x01, 0x03, 0x01, 0x01, 0x03},
 };
 
 struct bcm_kona_i2c_dev {
@@ -127,8 +121,8 @@ struct bcm_kona_i2c_dev {
 };
 
 /* Keep these two defines in sync */
-#define DEF_SPD 10
-#define DEF_SPD_ENUM BCM_SPD_100K
+#define DEF_SPD I2C_SPEED_STANDARD_RATE
+#define DEF_SPD_ENUM IC_SPEED_MODE_STANDARD
 
 #define DEF_DEVICE(num) \
 {(void *)CONFIG_SYS_I2C_BASE##num, DEF_SPD, _cfg_table[DEF_SPD_ENUM]}
@@ -560,14 +554,14 @@ static uint bcm_kona_i2c_assign_bus_speed(struct 
bcm_kona_i2c_dev *dev,
  uint speed)
 {
switch (speed) {
-   case 10:
-   dev->std_cfg = _cfg_table[BCM_SPD_100K];
+   case I2C_SPEED_STANDARD_RATE:
+   dev->std_cfg = _cfg_table[IC_SPEED_MODE_STANDARD];
break;
-   case 40:
-   dev->std_cfg = _cfg_table[BCM_SPD_400K];
+   case I2C_SPEED_FAST_RATE:
+   dev->std_cfg = _cfg_table[IC_SPEED_MODE_FAST];
break;
-   case 100:
-   dev->std_cfg = _cfg_table[BCM_SPD_1MHZ];
+   case I2C_SPEED_FAST_PLUS_RATE:
+   dev->std_cfg = _cfg_table[IC_SPEED_MODE_FAST_PLUS];
break;
default:
printf("%d hz bus speed not supported\n", speed);
-- 
2.24.1.735.g03f4e72817-goog