Re: [PATCH v2 2/5] phycore_imx8mp: Move default bootcmd to board env

2024-03-12 Thread Teresa Remmet
Am Dienstag, dem 12.03.2024 um 09:59 +0100 schrieb Leonard Anderweit:
> Move the default bootcmd from the defconfig to the board environment.
> No change in functionality.
> 
> Signed-off-by: Leonard Anderweit 

Tested-by: Teresa Remmet 

> ---
>  board/phytec/phycore_imx8mp/phycore_imx8mp.env | 12 
>  configs/phycore-imx8mp_defconfig   |  2 --
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/board/phytec/phycore_imx8mp/phycore_imx8mp.env
> b/board/phytec/phycore_imx8mp/phycore_imx8mp.env
> index 6d15b7f3dc9f..73202c3b129a 100644
> --- a/board/phytec/phycore_imx8mp/phycore_imx8mp.env
> +++ b/board/phytec/phycore_imx8mp/phycore_imx8mp.env
> @@ -1,3 +1,15 @@
> +bootcmd=
> +   if test ${dofastboot} = 1; then
> +   fastboot 0;
> +   fi;
> +   mmc dev ${mmcdev};
> +   if mmc rescan; then
> +   if run loadimage; then
> +   run mmcboot;
> +   else
> +   run netboot;
> +   fi;
> +   fi;
>  console=ttymxc0,115200
>  dofastboot=0
>  emmc_dev=2
> diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-
> imx8mp_defconfig
> index b3a7bbd79bb6..fd492eba3c10 100644
> --- a/configs/phycore-imx8mp_defconfig
> +++ b/configs/phycore-imx8mp_defconfig
> @@ -25,8 +25,6 @@ CONFIG_FIT=y
>  CONFIG_FIT_EXTERNAL_OFFSET=0x3000
>  CONFIG_SPL_LOAD_FIT=y
>  CONFIG_OF_SYSTEM_SETUP=y
> -CONFIG_USE_BOOTCOMMAND=y
> -CONFIG_BOOTCOMMAND="if test ${dofastboot} = 1; then fastboot 0; fi;
> mmc dev ${mmcdev}; if mmc rescan; then if run loadimage; then run
> mmcboot; else run netboot; fi; fi;"
>  CONFIG_DEFAULT_FDT_FILE="oftree"
>  CONFIG_SYS_CBSIZE=2048
>  CONFIG_SYS_PBSIZE=2074

-- 
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber,
Dipl.-Ing. (FH) Markus Lickes | Handelsregister Mainz HRB 4656 |
Finanzamt Mainz | St.Nr. 266500608, DE 149059855


[PATCH v2 2/5] phycore_imx8mp: Move default bootcmd to board env

2024-03-12 Thread Leonard Anderweit
Move the default bootcmd from the defconfig to the board environment.
No change in functionality.

Signed-off-by: Leonard Anderweit 
---
 board/phytec/phycore_imx8mp/phycore_imx8mp.env | 12 
 configs/phycore-imx8mp_defconfig   |  2 --
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/board/phytec/phycore_imx8mp/phycore_imx8mp.env 
b/board/phytec/phycore_imx8mp/phycore_imx8mp.env
index 6d15b7f3dc9f..73202c3b129a 100644
--- a/board/phytec/phycore_imx8mp/phycore_imx8mp.env
+++ b/board/phytec/phycore_imx8mp/phycore_imx8mp.env
@@ -1,3 +1,15 @@
+bootcmd=
+   if test ${dofastboot} = 1; then
+   fastboot 0;
+   fi;
+   mmc dev ${mmcdev};
+   if mmc rescan; then
+   if run loadimage; then
+   run mmcboot;
+   else
+   run netboot;
+   fi;
+   fi;
 console=ttymxc0,115200
 dofastboot=0
 emmc_dev=2
diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-imx8mp_defconfig
index b3a7bbd79bb6..fd492eba3c10 100644
--- a/configs/phycore-imx8mp_defconfig
+++ b/configs/phycore-imx8mp_defconfig
@@ -25,8 +25,6 @@ CONFIG_FIT=y
 CONFIG_FIT_EXTERNAL_OFFSET=0x3000
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_OF_SYSTEM_SETUP=y
-CONFIG_USE_BOOTCOMMAND=y
-CONFIG_BOOTCOMMAND="if test ${dofastboot} = 1; then fastboot 0; fi; mmc dev 
${mmcdev}; if mmc rescan; then if run loadimage; then run mmcboot; else run 
netboot; fi; fi;"
 CONFIG_DEFAULT_FDT_FILE="oftree"
 CONFIG_SYS_CBSIZE=2048
 CONFIG_SYS_PBSIZE=2074
-- 
2.25.1