Re: [PATCH v2 2/6] lib: Drop SHA512_ALGO in lieu of SHA512

2021-09-09 Thread Andreas Schwab
On Sep 02 2021, Alexandru Gagniuc wrote: > diff --git a/lib/crypt/Kconfig b/lib/crypt/Kconfig > index 5495ae8d4c..6a50029642 100644 > --- a/lib/crypt/Kconfig > +++ b/lib/crypt/Kconfig > @@ -20,7 +20,7 @@ config CRYPT_PW_SHA256 > config CRYPT_PW_SHA512 > bool "Provide sha512crypt" >

Re: [PATCH v2 2/6] lib: Drop SHA512_ALGO in lieu of SHA512

2021-09-08 Thread Tom Rini
On Thu, Sep 02, 2021 at 07:54:18PM -0500, Alexandru Gagniuc wrote: > SHA512_ALGO was used as a "either SHA512 or SHA384", although the > implementations of these two algorithms share a majority of code. > > From a Kconfig interface perspective, it makes sense to present two > distinct options.

[PATCH v2 2/6] lib: Drop SHA512_ALGO in lieu of SHA512

2021-09-02 Thread Alexandru Gagniuc
SHA512_ALGO was used as a "either SHA512 or SHA384", although the implementations of these two algorithms share a majority of code. >From a Kconfig interface perspective, it makes sense to present two distinct options. This requires #ifdefing out the SHA512 implementation from sha512.c. The