Re: [PATCH v2 8/8] imx: imx8: apalis: switch to binman
Hi Marcel, On 15.11.22 11:05, Marcel Ziswiler wrote: On Sat, 2022-11-12 at 17:26 +0100, sba...@denx.de wrote: Switch to use binman to pack images Signed-off-by: Oliver Graute Applied to u-boot-imx, master, thanks ! Quick question: Why exactly did this get applied? This really does not work at all! Mmhhh...I have seen the series was , and yes, I have seen you planned to test it. It is my fault, I have not disable this single patch from the serier when I applied. I will revert it. Stefano Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de =
Re: [PATCH v2 8/8] imx: imx8: apalis: switch to binman
On Sat, 2022-11-12 at 17:26 +0100, sba...@denx.de wrote: > > Switch to use binman to pack images > > Signed-off-by: Oliver Graute > Applied to u-boot-imx, master, thanks ! Quick question: Why exactly did this get applied? This really does not work at all! > Best regards, > Stefano Babic
[PATCH v2 8/8] imx: imx8: apalis: switch to binman
> Switch to use binman to pack images > Signed-off-by: Oliver Graute Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de =
Re: [PATCH v2 8/8] imx: imx8: apalis: switch to binman
On 09/11/22, Marcel Ziswiler wrote: > Hi Oliver > > Thanks for working on this. > > On Fri, 2022-11-04 at 16:03 +0100, Oliver Graute wrote: > > Switch to use binman to pack images > > > > Signed-off-by: Oliver Graute > > --- > > Changes for v2 > > - use common imx8qm-u-boot.dtsi > > - guard SPL nodes with CONFIG_SPL > > I don't think it is that simple. Even after guarding them SPL nodes the > flash.bin one still references them, > not? And yes, so far we never used SPL for them 8/8X as that honestly does > not really make much sense given the > SCFW does the actual RAM initialisation. Anyway, I am not very clear on > how/what exactly that all means now. On imx8qm-rom7720 we use the SCFW for RAM initalisation too but still use SPL. > > Another topic is that flash.bin is now just the SPL whereas previously > u-boot-dtb.imx was the entire thing. But > again, that could have been related to us not using SPL. yes, thats right, if I guard the SPL subnode in imx-boot node I get a 0 byte flash.bin. At the moment I don't know the best way here. I would be grateful for some hints here. > > CONFIG_FIT=y +CONFIG_FIT_EXTERNAL_OFFSET=0x3000 > > Also not quite sure what exactly that is now. its introduced by commit 3814fcba12323b9f30f39ee5455f3f9a7e955c64 Best regards, Oliver
Re: [PATCH v2 8/8] imx: imx8: apalis: switch to binman
Hi Oliver
Thanks for working on this.
On Fri, 2022-11-04 at 16:03 +0100, Oliver Graute wrote:
> Switch to use binman to pack images
>
> Signed-off-by: Oliver Graute
> ---
> Changes for v2
> - use common imx8qm-u-boot.dtsi
> - guard SPL nodes with CONFIG_SPL
I don't think it is that simple. Even after guarding them SPL nodes the
flash.bin one still references them,
not? And yes, so far we never used SPL for them 8/8X as that honestly does not
really make much sense given the
SCFW does the actual RAM initialisation. Anyway, I am not very clear on
how/what exactly that all means now.
Another topic is that flash.bin is now just the SPL whereas previously
u-boot-dtb.imx was the entire thing. But
again, that could have been related to us not using SPL.
> arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 2 ++
> arch/arm/dts/imx8qm-u-boot.dtsi | 2 ++
> arch/arm/mach-imx/imx8/Kconfig | 1 +
> configs/apalis-imx8_defconfig | 1 +
> 4 files changed, 6 insertions(+)
>
> diff --git a/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
> b/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
> index 956d724979..8fd0e33d2b 100644
> --- a/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
> +++ b/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
> @@ -3,6 +3,8 @@
> * Copyright 2019 Toradex AG
> */
>
> +#include "imx8qm-u-boot.dtsi"
> +
> {
> u-boot,dm-pre-proper;
> };
> diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi
> index f3fc90c9bb..3507489a81 100644
> --- a/arch/arm/dts/imx8qm-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qm-u-boot.dtsi
> @@ -10,6 +10,7 @@
> };
>
> {
> +#ifdef CONFIG_SPL
> u-boot-spl-ddr {
> align = <4>;
> align-size = <4>;
> @@ -33,6 +34,7 @@
> };
> };
> };
> +#endif
>
> itb {
> filename = "u-boot.itb";
> diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
> index 37d12d1895..91bd888308 100644
> --- a/arch/arm/mach-imx/imx8/Kconfig
> +++ b/arch/arm/mach-imx/imx8/Kconfig
> @@ -46,6 +46,7 @@ choice
>
> config TARGET_APALIS_IMX8
> bool "Support Apalis iMX8 module"
> + select BINMAN
> select BOARD_LATE_INIT
> select IMX8QM
>
> diff --git a/configs/apalis-imx8_defconfig b/configs/apalis-imx8_defconfig
> index 32e105a557..0c331b62cb 100644
> --- a/configs/apalis-imx8_defconfig
> +++ b/configs/apalis-imx8_defconfig
> @@ -17,6 +17,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x8020
> CONFIG_REMAKE_ELF=y
> CONFIG_FIT=y
> +CONFIG_FIT_EXTERNAL_OFFSET=0x3000
Also not quite sure what exactly that is now.
> CONFIG_FIT_VERBOSE=y
> CONFIG_OF_SYSTEM_SETUP=y
> CONFIG_LOG=y
Cheers
Marcel
[PATCH v2 8/8] imx: imx8: apalis: switch to binman
Switch to use binman to pack images
Signed-off-by: Oliver Graute
---
Changes for v2
- use common imx8qm-u-boot.dtsi
- guard SPL nodes with CONFIG_SPL
arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi | 2 ++
arch/arm/dts/imx8qm-u-boot.dtsi| 2 ++
arch/arm/mach-imx/imx8/Kconfig | 1 +
configs/apalis-imx8_defconfig | 1 +
4 files changed, 6 insertions(+)
diff --git a/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
b/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
index 956d724979..8fd0e33d2b 100644
--- a/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
+++ b/arch/arm/dts/fsl-imx8qm-apalis-u-boot.dtsi
@@ -3,6 +3,8 @@
* Copyright 2019 Toradex AG
*/
+#include "imx8qm-u-boot.dtsi"
+
{
u-boot,dm-pre-proper;
};
diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi
index f3fc90c9bb..3507489a81 100644
--- a/arch/arm/dts/imx8qm-u-boot.dtsi
+++ b/arch/arm/dts/imx8qm-u-boot.dtsi
@@ -10,6 +10,7 @@
};
{
+#ifdef CONFIG_SPL
u-boot-spl-ddr {
align = <4>;
align-size = <4>;
@@ -33,6 +34,7 @@
};
};
};
+#endif
itb {
filename = "u-boot.itb";
diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
index 37d12d1895..91bd888308 100644
--- a/arch/arm/mach-imx/imx8/Kconfig
+++ b/arch/arm/mach-imx/imx8/Kconfig
@@ -46,6 +46,7 @@ choice
config TARGET_APALIS_IMX8
bool "Support Apalis iMX8 module"
+ select BINMAN
select BOARD_LATE_INIT
select IMX8QM
diff --git a/configs/apalis-imx8_defconfig b/configs/apalis-imx8_defconfig
index 32e105a557..0c331b62cb 100644
--- a/configs/apalis-imx8_defconfig
+++ b/configs/apalis-imx8_defconfig
@@ -17,6 +17,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x8020
CONFIG_REMAKE_ELF=y
CONFIG_FIT=y
+CONFIG_FIT_EXTERNAL_OFFSET=0x3000
CONFIG_FIT_VERBOSE=y
CONFIG_OF_SYSTEM_SETUP=y
CONFIG_LOG=y
--
2.17.1
