Re: [PATCH v3 03/16] soc: ti: k3-socinfo: Add entry for J784S4 SoC
On 11:21-20230912, Marcel Ziswiler wrote: > On Fri, 2023-09-08 at 16:35 +0530, Apurva Nandan wrote: > > Add support for J784S4 SoC Identification. > > > > Signed-off-by: Hari Nagalla > > Signed-off-by: Apurva Nandan > > --- > > arch/arm/mach-k3/include/mach/hardware.h | 1 + > > drivers/soc/soc_ti_k3.c | 3 +++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/arch/arm/mach-k3/include/mach/hardware.h > > b/arch/arm/mach-k3/include/mach/hardware.h > > index 03b18f6bad..bada87d0b2 100644 > > --- a/arch/arm/mach-k3/include/mach/hardware.h > > +++ b/arch/arm/mach-k3/include/mach/hardware.h > > @@ -50,6 +50,7 @@ > > #define JTAG_ID_PARTNO_J721S2 0xbb75 > > #define JTAG_ID_PARTNO_AM62X 0xbb7e > > #define JTAG_ID_PARTNO_AM62AX 0xbb8d > > +#define JTAG_ID_PARTNO_J784S4 0xbb80 > > Not sure whether it would be smarter to sort this based on the JTAG ID or the > name of the define like you did. The order followed at the moment is introduction order, which is not proper. Alpha sort on name is better.. but the file already does'nt follow the same.. I suggest doing an alpha sort of the macro based on names as a cleanup patch prior to introducing. > > > #define K3_SOC_ID(id, ID) \ > > static inline bool soc_is_##id(void) \ > > diff --git a/drivers/soc/soc_ti_k3.c b/drivers/soc/soc_ti_k3.c > > index b720131ae5..6f7fcf9e11 100644 > > --- a/drivers/soc/soc_ti_k3.c > > +++ b/drivers/soc/soc_ti_k3.c > > @@ -45,6 +45,9 @@ static const char *get_family_string(u32 idreg) > > case JTAG_ID_PARTNO_AM62AX: > > family = "AM62AX"; > > break; > > + case JTAG_ID_PARTNO_J784S4: > > + family = "J784S4"; > > + break; > > default: > > family = "Unknown Silicon"; > > }; -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Re: [PATCH v3 03/16] soc: ti: k3-socinfo: Add entry for J784S4 SoC
On Fri, 2023-09-08 at 16:35 +0530, Apurva Nandan wrote: > Add support for J784S4 SoC Identification. > > Signed-off-by: Hari Nagalla > Signed-off-by: Apurva Nandan > --- > arch/arm/mach-k3/include/mach/hardware.h | 1 + > drivers/soc/soc_ti_k3.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/arch/arm/mach-k3/include/mach/hardware.h > b/arch/arm/mach-k3/include/mach/hardware.h > index 03b18f6bad..bada87d0b2 100644 > --- a/arch/arm/mach-k3/include/mach/hardware.h > +++ b/arch/arm/mach-k3/include/mach/hardware.h > @@ -50,6 +50,7 @@ > #define JTAG_ID_PARTNO_J721S2 0xbb75 > #define JTAG_ID_PARTNO_AM62X 0xbb7e > #define JTAG_ID_PARTNO_AM62AX 0xbb8d > +#define JTAG_ID_PARTNO_J784S4 0xbb80 Not sure whether it would be smarter to sort this based on the JTAG ID or the name of the define like you did. > #define K3_SOC_ID(id, ID) \ > static inline bool soc_is_##id(void) \ > diff --git a/drivers/soc/soc_ti_k3.c b/drivers/soc/soc_ti_k3.c > index b720131ae5..6f7fcf9e11 100644 > --- a/drivers/soc/soc_ti_k3.c > +++ b/drivers/soc/soc_ti_k3.c > @@ -45,6 +45,9 @@ static const char *get_family_string(u32 idreg) > case JTAG_ID_PARTNO_AM62AX: > family = "AM62AX"; > break; > + case JTAG_ID_PARTNO_J784S4: > + family = "J784S4"; > + break; > default: > family = "Unknown Silicon"; > };
[PATCH v3 03/16] soc: ti: k3-socinfo: Add entry for J784S4 SoC
Add support for J784S4 SoC Identification. Signed-off-by: Hari Nagalla Signed-off-by: Apurva Nandan --- arch/arm/mach-k3/include/mach/hardware.h | 1 + drivers/soc/soc_ti_k3.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/mach-k3/include/mach/hardware.h b/arch/arm/mach-k3/include/mach/hardware.h index 03b18f6bad..bada87d0b2 100644 --- a/arch/arm/mach-k3/include/mach/hardware.h +++ b/arch/arm/mach-k3/include/mach/hardware.h @@ -50,6 +50,7 @@ #define JTAG_ID_PARTNO_J721S2 0xbb75 #define JTAG_ID_PARTNO_AM62X 0xbb7e #define JTAG_ID_PARTNO_AM62AX 0xbb8d +#define JTAG_ID_PARTNO_J784S4 0xbb80 #define K3_SOC_ID(id, ID) \ static inline bool soc_is_##id(void) \ diff --git a/drivers/soc/soc_ti_k3.c b/drivers/soc/soc_ti_k3.c index b720131ae5..6f7fcf9e11 100644 --- a/drivers/soc/soc_ti_k3.c +++ b/drivers/soc/soc_ti_k3.c @@ -45,6 +45,9 @@ static const char *get_family_string(u32 idreg) case JTAG_ID_PARTNO_AM62AX: family = "AM62AX"; break; + case JTAG_ID_PARTNO_J784S4: + family = "J784S4"; + break; default: family = "Unknown Silicon"; }; -- 2.34.1
