Re: [PATCH v3 1/3] arm: dts: imx93-phyboard-segin: Add USB support

[Fabio Estevam]

On Thu, Mar 21, 2024 at 4:17 PM Marek Vasut  wrote:
>
> On 3/21/24 3:45 PM, Mathieu Othacehe wrote:
> > Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are
> > not connected to the SoC.
> >
> > This
>
> "This addition to ...-u-boot.dtsi is temporary, ..." would be clearer.

I fixed as Marek's suggestion and applied it to u-boot-imx/next, thanks.

Re: [PATCH v3 1/3] arm: dts: imx93-phyboard-segin: Add USB support

[Marek Vasut]

On 3/21/24 3:45 PM, Mathieu Othacehe wrote:

Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are
not connected to the SoC.

This


"This addition to ...-u-boot.dtsi is temporary, ..." would be clearer.


is temporary, until USB support is added to imx93-phyboard-segin.dts
in Linux.

Signed-off-by: Mathieu Othacehe 


Reviewed-by: Marek Vasut 

Re: [PATCH v3 1/3] arm: dts: imx93-phyboard-segin: Add USB support

[Fabio Estevam]

Hi Mathieu,

On Thu, Mar 21, 2024 at 11:46 AM Mathieu Othacehe  wrote:
>
> Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are
> not connected to the SoC.
>
> This is temporary, until USB support is added to imx93-phyboard-segin.dts
> in Linux.
>
> Signed-off-by: Mathieu Othacehe 

Thanks, this looks better:

Reviewed-by: Fabio Estevam 

[PATCH v3 1/3] arm: dts: imx93-phyboard-segin: Add USB support

[Mathieu Othacehe]

Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are
not connected to the SoC.

This is temporary, until USB support is added to imx93-phyboard-segin.dts
in Linux.

Signed-off-by: Mathieu Othacehe 
---
 arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi 
b/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
index 8bf28c2de87..6897c91f4d9 100644
--- a/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
+++ b/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
@@ -121,6 +121,21 @@
bootph-some-ram;
 };
 
+/*
+ * Remove once USB support is added to imx93-phyboard-segin.dts upstream.
+ */
+ {
+   disable-over-current;
+   dr_mode = "otg";
+   status = "okay";
+};
+
+ {
+   disable-over-current;
+   dr_mode = "host";
+   status = "okay";
+};
+
  {
bootph-pre-ram;
bootph-some-ram;
-- 
2.41.0