Re: [PATCH v3 4/4] spl: fit: improve spl_nand_fit_read(...) readability

2020-07-08 Thread Tom Rini
On Wed, May 27, 2020 at 01:56:21PM +0200, Dario Binacchi wrote: > Replacing the ret variable with err and handling first the error > condition about the value returned by the spl_nand_fit_read routine, > improves the code readability. > Furthermore, the 'else' int the 'else return ret'

Re: [PATCH v3 4/4] spl: fit: improve spl_nand_fit_read(...) readability

2020-05-31 Thread Simon Glass
Hi Dario, On Wed, 27 May 2020 at 05:56, Dario Binacchi wrote: > > Replacing the ret variable with err and handling first the error > condition about the value returned by the spl_nand_fit_read routine, > improves the code readability. > Furthermore, the 'else' int the 'else return ret'

[PATCH v3 4/4] spl: fit: improve spl_nand_fit_read(...) readability

2020-05-27 Thread Dario Binacchi
Replacing the ret variable with err and handling first the error condition about the value returned by the spl_nand_fit_read routine, improves the code readability. Furthermore, the 'else' int the 'else return ret' instruction was useless. cc: Michael Trimarchi Signed-off-by: Dario Binacchi ---