Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-28 Thread Matthias Brugger
On 22/10/2021 17:09, Tom Rini wrote: On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: On Fri, 22 Oct 2021 12:09:19 +0200 Heinrich Schuchardt wrote: On 10/21/21 15:00, Marek Behún wrote: BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu platform in Kconfig?

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-27 Thread Peter Robinson
> > >> I also have been doing some packaging of u-boot for GNU Guix, where I > > >> suspect the stance wouldn't be as willing to accept such a compromise... > > >> > > >> So... I would *love* an option to be able to build a board-only config > > >> without any of the tools; > > > > > > Why is this

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-27 Thread Tom Rini
On Fri, Oct 22, 2021 at 12:46:59PM -0700, Vagrant Cascadian wrote: > On 2021-10-22, Andre Przywara wrote: > > On Fri, 22 Oct 2021 09:47:35 -0700 > > Vagrant Cascadian wrote: > >> On 2021-10-22, Tom Rini wrote: > >> > On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: > >> >> On

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Vagrant Cascadian
On 2021-10-22, Andre Przywara wrote: > On Fri, 22 Oct 2021 09:47:35 -0700 > Vagrant Cascadian wrote: >> On 2021-10-22, Tom Rini wrote: >> > On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: >> >> On Fri, 22 Oct 2021 11:09:27 -0400 >> >> Tom Rini wrote: >> >> >> > On Fri, Oct

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 09:47:35 -0700 Vagrant Cascadian wrote: Hi, > On 2021-10-22, Tom Rini wrote: > > On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: > >> On Fri, 22 Oct 2021 11:09:27 -0400 > >> Tom Rini wrote: > > >> > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Pali Rohár
On Friday 22 October 2021 09:47:35 Vagrant Cascadian wrote: > do some boards use board-specific tools as part of their build processes? Lot of boards are using mkimage for generating final U-Boot binary. Prior U-Boot 2021.10 all 32-bit mvebu boards used own specific version of mkimage to

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Vagrant Cascadian
On 2021-10-22, Tom Rini wrote: > On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: >> On Fri, 22 Oct 2021 11:09:27 -0400 >> Tom Rini wrote: >> > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: >> > > On Fri, 22 Oct 2021 12:09:19 +0200 >> > > Heinrich Schuchardt wrote:

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: > On Fri, 22 Oct 2021 11:09:27 -0400 > Tom Rini wrote: > > Hi, > > > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > > > On Fri, 22 Oct 2021 12:09:19 +0200 > > > Heinrich Schuchardt wrote: > > > > > > > On

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 11:09:27 -0400 Tom Rini wrote: Hi, > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > > On Fri, 22 Oct 2021 12:09:19 +0200 > > Heinrich Schuchardt wrote: > > > > > On 10/21/21 15:00, Marek Behún wrote: > > > > BTW, wouldn't it be enough to simply imply

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > On Fri, 22 Oct 2021 12:09:19 +0200 > Heinrich Schuchardt wrote: > > > On 10/21/21 15:00, Marek Behún wrote: > > > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > > > platform in Kconfig? > > > > > > > We

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Marek Behún
On Fri, 22 Oct 2021 12:09:19 +0200 Heinrich Schuchardt wrote: > On 10/21/21 15:00, Marek Behún wrote: > > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > > platform in Kconfig? > > > > We should only use 'imply' for suggested settings and never for hard >

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Heinrich Schuchardt
On 10/21/21 15:00, Marek Behún wrote: BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu platform in Kconfig? We should only use 'imply' for suggested settings and never for hard requirements. TOOLS_LIBCRYPTO already defaults to 'Y'. So implying it for mvebu would be

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Samuel Holland
On 10/21/21 8:00 AM, Marek Behún wrote: > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > platform in Kconfig? No, that would not do anything. For example: config ARMADA_32BIT imply TOOLS_LIBCRYPTO is equivalent to: config TOOLS_LIBCRYPTO

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Pali Rohár
On Thursday 21 October 2021 15:00:48 Marek Behún wrote: > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > platform in Kconfig? FYI https://lore.kernel.org/u-boot/20211021093304.25399-1-p...@kernel.org/ (forgot to CC)

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Marek Behún
BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu platform in Kconfig?

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-21 Thread Marek Behún
Hi Samuel, On Wed, 20 Oct 2021 09:14:11 -0500 Samuel Holland wrote: > Andre is correct. No version of this patch makes *any* change to *any* > in-tree defconfig build, because TOOLS_LIBCRYPTO=y in all defconfigs. > Even if I was to accept your assertion that it hides a possible error on >

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-20 Thread Samuel Holland
On 10/20/21 8:47 AM, Pali Rohár wrote: > On Wednesday 20 October 2021 14:29:02 Andre Przywara wrote: >> On Wed, 20 Oct 2021 09:29:25 +0200 >> Pali Rohár wrote: >> >> Hi, >> >>> On Tuesday 19 October 2021 21:44:51 Samuel Holland wrote: Some image types (kwbimage and mxsimage) always depend on

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-20 Thread Pali Rohár
On Wednesday 20 October 2021 14:29:02 Andre Przywara wrote: > On Wed, 20 Oct 2021 09:29:25 +0200 > Pali Rohár wrote: > > Hi, > > > On Tuesday 19 October 2021 21:44:51 Samuel Holland wrote: > > > Some image types (kwbimage and mxsimage) always depend on OpenSSL, so > > > they can only be

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-20 Thread Andre Przywara
On Wed, 20 Oct 2021 09:29:25 +0200 Pali Rohár wrote: Hi, > On Tuesday 19 October 2021 21:44:51 Samuel Holland wrote: > > Some image types (kwbimage and mxsimage) always depend on OpenSSL, so > > they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. > > Use Makefile logic to

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-20 Thread Pali Rohár
On Tuesday 19 October 2021 21:44:51 Samuel Holland wrote: > Some image types (kwbimage and mxsimage) always depend on OpenSSL, so > they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. > Use Makefile logic to conditionally link the files. > > Signed-off-by: Samuel Holland NAK.

[PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-19 Thread Samuel Holland
Some image types (kwbimage and mxsimage) always depend on OpenSSL, so they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. Use Makefile logic to conditionally link the files. Signed-off-by: Samuel Holland --- Changes in v4: - Do not select TOOLS_LIBCRYPTO anywhere Changes in