Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-27 Thread Bin Meng
Hi Matthias, On Wed, May 27, 2020 at 8:20 PM Matthias Brugger wrote: > > > > On 26/05/2020 10:07, Bin Meng wrote: > > Hi Simon, > > > > On Tue, May 26, 2020 at 5:41 AM Simon Glass wrote: > >> > >> Hi Sylwester, > >> > >> On Mon, 25 May 2020 at 11:42, Sylwester Nawrocki > >> wrote: > >>> > >>>

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-27 Thread Matthias Brugger
On 26/05/2020 10:07, Bin Meng wrote: > Hi Simon, > > On Tue, May 26, 2020 at 5:41 AM Simon Glass wrote: >> >> Hi Sylwester, >> >> On Mon, 25 May 2020 at 11:42, Sylwester Nawrocki >> wrote: >>> >>> Hi Simon, >>> >>> On 25.05.2020 19:04, Simon Glass wrote: On Mon, 25 May 2020 at 10:57,

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-26 Thread Sylwester Nawrocki
Hi, On 26.05.2020 09:49, Marek Szyprowski wrote: > On 25.05.2020 23:40, Simon Glass wrote: >> On Mon, 25 May 2020 at 11:42, Sylwester Nawrocki >> wrote: >>> On 25.05.2020 19:04, Simon Glass wrote: On Mon, 25 May 2020 at 10:57, Sylwester Nawrocki wrote: > On 25.05.2020 16:57,

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-26 Thread Bin Meng
Hi Simon, On Tue, May 26, 2020 at 5:41 AM Simon Glass wrote: > > Hi Sylwester, > > On Mon, 25 May 2020 at 11:42, Sylwester Nawrocki > wrote: > > > > Hi Simon, > > > > On 25.05.2020 19:04, Simon Glass wrote: > > > On Mon, 25 May 2020 at 10:57, Sylwester Nawrocki > > > wrote: > > >> On

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-26 Thread Marek Szyprowski
Hi Simon, On 25.05.2020 23:40, Simon Glass wrote: > On Mon, 25 May 2020 at 11:42, Sylwester Nawrocki > wrote: >> On 25.05.2020 19:04, Simon Glass wrote: >>> On Mon, 25 May 2020 at 10:57, Sylwester Nawrocki >>> wrote: On 25.05.2020 16:57, Simon Glass wrote: > On Mon, 25 May 2020 at

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-25 Thread Simon Glass
Hi Sylwester, On Mon, 25 May 2020 at 11:42, Sylwester Nawrocki wrote: > > Hi Simon, > > On 25.05.2020 19:04, Simon Glass wrote: > > On Mon, 25 May 2020 at 10:57, Sylwester Nawrocki > > wrote: > >> On 25.05.2020 16:57, Simon Glass wrote: > >>> On Mon, 25 May 2020 at 05:40, Sylwester Nawrocki

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-25 Thread Sylwester Nawrocki
Hi Simon, On 25.05.2020 19:04, Simon Glass wrote: > On Mon, 25 May 2020 at 10:57, Sylwester Nawrocki > wrote: >> On 25.05.2020 16:57, Simon Glass wrote: >>> On Mon, 25 May 2020 at 05:40, Sylwester Nawrocki >>> wrote: There might be hardware configurations where 64-bit data accesses

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-25 Thread Simon Glass
Hi Sylwester, On Mon, 25 May 2020 at 10:57, Sylwester Nawrocki wrote: > > Hi Simon, > > On 25.05.2020 16:57, Simon Glass wrote: > > On Mon, 25 May 2020 at 05:40, Sylwester Nawrocki > > wrote: > >> > >> There might be hardware configurations where 64-bit data accesses > >> to XHCI registers are

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-25 Thread Sylwester Nawrocki
Hi Simon, On 25.05.2020 16:57, Simon Glass wrote: > On Mon, 25 May 2020 at 05:40, Sylwester Nawrocki > wrote: >> >> There might be hardware configurations where 64-bit data accesses >> to XHCI registers are not supported properly. This patch removes >> the readq/writeq so always two 32-bit

Re: [PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-25 Thread Simon Glass
Hi Sylwester, On Mon, 25 May 2020 at 05:40, Sylwester Nawrocki wrote: > > There might be hardware configurations where 64-bit data accesses > to XHCI registers are not supported properly. This patch removes > the readq/writeq so always two 32-bit accesses are used to read/write > 64-bit XHCI

[PATCH v4 2/9] usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq

2020-05-25 Thread Sylwester Nawrocki
There might be hardware configurations where 64-bit data accesses to XHCI registers are not supported properly. This patch removes the readq/writeq so always two 32-bit accesses are used to read/write 64-bit XHCI registers, similarly as it is done in Linux kernel. This patch fixes operation of