Re: [PATCH v7 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE
Dear Simon, In message <20211016003339.723169-4-...@chromium.org> you wrote: > Add mention of this option this it does a similar thing to the text > environment. > > Suggested-by: Rasmus Villemoes > > Signed-off-by: Simon Glass ... > +The format is the same as accepted by the mkenvimage tool: lines containing > +key=value pairs, blank lines and lines beginning with # are ignored. This is misleading. It can be read as: "lines containing key=value pairs ... are ignored." This reminds me of a sign in the door of a shop in Cornwall which read: "No prams or dogs or food being eaten!" I mean eating dogs is bad enough, but eating prams? ? ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "There's only one way to have a happy marriage and as soon as I learn what it is I'll get married again." - Clint Eastwood
[PATCH v7 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE
Add mention of this option this it does a similar thing to the text environment. Suggested-by: Rasmus Villemoes Signed-off-by: Simon Glass --- Changes in v7: - Add new patch to explain the relationship with DEFAULT_ENV_FILE doc/usage/environment.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/usage/environment.rst b/doc/usage/environment.rst index 667fd193ea1..a2410607e9f 100644 --- a/doc/usage/environment.rst +++ b/doc/usage/environment.rst @@ -454,3 +454,18 @@ The signature of the callback functions is:: include/search.h The return value is 0 if the variable change is accepted and 1 otherwise. + + +External environment file +- + +The `CONFIG_USE_DEFAULT_ENV_FILE` option provides a way to bypass the +environment generation in U-Boot. If enabled, then `CONFIG_DEFAULT_ENV_FILE` +provides the name of a file which is converted into the environment, +completely bypassing the standard environment variables in `env_default.h`. + +The format is the same as accepted by the mkenvimage tool: lines containing +key=value pairs, blank lines and lines beginning with # are ignored. + +Future work may unify this feature with the text-based environment, perhaps +moving the contents of `env_default.h` to a text file. -- 2.33.0.1079.g6e70778dc9-goog
