Antwort: Re: [RFC PATCH] serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()

2020-02-28 Thread Wolfgang Wallner
Hi Bin, -"Bin Meng" schrieb: - > Hi Wolfgang, > > [snip] > > Unfortunately this patch breaks several ARM board: > > +drivers/built-in.o: In function `ofnode_get_parent': > +drivers/core/ofnode.c:235: undefined reference to `fdt_parent_offset' > +drivers/built-in.o: In function

Re: [RFC PATCH] serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()

2020-02-28 Thread Bin Meng
Hi Wolfgang, On Fri, Feb 28, 2020 at 3:50 PM Bin Meng wrote: > > On Thu, Feb 27, 2020 at 5:36 PM Bin Meng wrote: > > > > On Tue, Feb 18, 2020 at 8:36 PM Wolfgang Wallner > > wrote: > > > > > > Currently the ofdata_to_platdata() method calls dev_read_addr_pci(), > > > which potentially accesses

Re: [RFC PATCH] serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()

2020-02-27 Thread Bin Meng
On Thu, Feb 27, 2020 at 5:36 PM Bin Meng wrote: > > On Tue, Feb 18, 2020 at 8:36 PM Wolfgang Wallner > wrote: > > > > Currently the ofdata_to_platdata() method calls dev_read_addr_pci(), > > which potentially accesses the parent PCI bus. If this happens before > > the parent PCI bus is probed

Re: [RFC PATCH] serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()

2020-02-27 Thread Bin Meng
On Tue, Feb 18, 2020 at 8:36 PM Wolfgang Wallner wrote: > > Currently the ofdata_to_platdata() method calls dev_read_addr_pci(), > which potentially accesses the parent PCI bus. If this happens before > the parent PCI bus is probed the resulting address will be wrong. > > This behavior was

Re: [RFC PATCH] serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()

2020-02-18 Thread Simon Glass
On Tue, 18 Feb 2020 at 05:36, Wolfgang Wallner wrote: > > Currently the ofdata_to_platdata() method calls dev_read_addr_pci(), > which potentially accesses the parent PCI bus. If this happens before > the parent PCI bus is probed the resulting address will be wrong. > > This behavior was

[RFC PATCH] serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()

2020-02-18 Thread Wolfgang Wallner
Currently the ofdata_to_platdata() method calls dev_read_addr_pci(), which potentially accesses the parent PCI bus. If this happens before the parent PCI bus is probed the resulting address will be wrong. This behavior was triggered by commit 82de42fa1468 ("dm: core: Allocate parent data separate