Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-08 Thread Wolfgang Denk
Dear Sean, In message <4aa7ff19-b774-0d67-b96a-9c0c9290a...@gmail.com> you wrote: > > Without pipes, how do bourne-style shells communicate? Sure you can > transfer data into functions using arguments, but what about the other > way around? Numeric return values? Global variables? I think these ar

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-07 Thread Sean Anderson
On 7/5/21 1:50 PM, Wolfgang Denk wrote: Dear Sean, In message <5a967151-94f0-6037-2d02-0114c43b8...@gmail.com> you wrote: AIUI hush has diverged significantly from what U-Boot has. This would not be an "update" moreso than a complete port in the style of the current series. Agreed. However,

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Wolfgang Denk
Dear Sean, In message <5a967151-94f0-6037-2d02-0114c43b8...@gmail.com> you wrote: > > AIUI hush has diverged significantly from what U-Boot has. This would > not be an "update" moreso than a complete port in the style of the > current series. Agreed. However, as you write this it sounds like a b

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Sean Anderson
On 7/5/21 11:29 AM, Simon Glass wrote: Hi, On Mon, 5 Jul 2021 at 08:42, Sean Anderson wrote: On 7/5/21 1:07 AM, Steve Bennett wrote: On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: Dear Sean, In message you wrote: Well, since Hush was never updated, I don't believe LIL will be either.

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Simon Glass
Hi, On Mon, 5 Jul 2021 at 08:42, Sean Anderson wrote: > > On 7/5/21 1:07 AM, Steve Bennett wrote: > > On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: > >> > >> Dear Sean, > >> > >> In message you wrote: > >>> > >>> Well, since Hush was never updated, I don't believe LIL will be either. > >> > >

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Sean Anderson
On 7/5/21 1:07 AM, Steve Bennett wrote: On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: Dear Sean, In message you wrote: Well, since Hush was never updated, I don't believe LIL will be either. Let's please be exact here: Hus has never been updated _in_U-Boot_, but it has seen a lot of ch

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-04 Thread Steve Bennett
On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: > > Dear Sean, > > In message you wrote: >> >> Well, since Hush was never updated, I don't believe LIL will be either. > > Let's please be exact here: Hus has never been updated _in_U-Boot_, > but it has seen a lot of changes upstream, which app

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-03 Thread Wolfgang Denk
Dear Sean, In message you wrote: > > Well, since Hush was never updated, I don't believe LIL will be either. Let's please be exact here: Hus has never been updated _in_U-Boot_, but it has seen a lot of changes upstream, which apparently fix all the issues that motivated you to look for a replace

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-02 Thread Sean Anderson
On 7/2/21 6:18 PM, Kostas Michalopoulos wrote: On 7/2/2021 4:38 PM, Sean Anderson wrote: I have not. I'm not sure what changes I've made are compatible with the vision he has for LIL. He's CC'd on this series, so perhaps he can comment. Yeah, sadly several of the changes i've seen in the code

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-02 Thread Kostas Michalopoulos
On 7/2/2021 4:38 PM, Sean Anderson wrote: I have not. I'm not sure what changes I've made are compatible with the vision he has for LIL. He's CC'd on this series, so perhaps he can comment. Yeah, sadly several of the changes i've seen in the code are not backwards compatible and backwards comp

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-02 Thread Tom Rini
On Fri, Jul 02, 2021 at 09:38:26AM -0400, Sean Anderson wrote: > On 7/2/21 4:36 AM, Rasmus Villemoes wrote: > > On 01/07/2021 08.15, Sean Anderson wrote: > > > Apparently strdup is not portable, so LIL used its own. Use strdup. > > > > You could reduce the churn by just making strclone "#define st

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-02 Thread Sean Anderson
On 7/2/21 4:36 AM, Rasmus Villemoes wrote: On 01/07/2021 08.15, Sean Anderson wrote: Apparently strdup is not portable, so LIL used its own. Use strdup. You could reduce the churn by just making strclone "#define strclone(x) strdup(x)", but I suppose you end up modifying the upstream code so m

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-02 Thread Wolfgang Denk
Dear Rasmus, In message you wrote: > > But that begs the question: What is the long-term plan for this? While > it does seem to be an improvement compared to hush, will we ever be able > to incorporate fixes&features from upstream, or will this code end up in > the same situation as hush? I woul

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-02 Thread Rasmus Villemoes
On 01/07/2021 08.15, Sean Anderson wrote: > Apparently strdup is not portable, so LIL used its own. Use strdup. You could reduce the churn by just making strclone "#define strclone(x) strdup(x)", but I suppose you end up modifying the upstream code so much that there's not really anything gained b

[RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-06-30 Thread Sean Anderson
Apparently strdup is not portable, so LIL used its own. Use strdup. Signed-off-by: Sean Anderson --- common/cli_lil.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/common/cli_lil.c b/common/cli_lil.c index c8c6986fe1..294d79e86e 100644 --- a/co