Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-06-03 Thread Sam Edwards
Hi again Andre, On 12/5/22 17:45, Andre Przywara wrote: diff --git a/arch/arm/mach-sunxi/board.c b/arch/arm/mach-sunxi/board.c index b6ffbff883c..3763ec3d2e4 100644 --- a/arch/arm/mach-sunxi/board.c +++ b/arch/arm/mach-sunxi/board.c @@ -177,7 +177,7 @@ static int gpio_init(void) #error

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-05-26 Thread Andre Przywara
On Thu, 25 May 2023 21:25:57 +0300 Maksim Kiselev wrote: Hi Maksim, > Could you please include this fix for i2c in the next version of this > series. > > diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c > index 93bbc6916e..d088ea75b9 100644 > --- a/drivers/i2c/mvtwsi.c > +++

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-05-25 Thread Maksim Kiselev
Hi, Andre Could you please include this fix for i2c in the next version of this series. diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c index 93bbc6916e..d088ea75b9 100644 --- a/drivers/i2c/mvtwsi.c +++ b/drivers/i2c/mvtwsi.c @@ -124,7 +124,7 @@ enum mvtwsi_ctrl_register_fields {   *

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-05-17 Thread Maxim Kiselev
Hi Sam, > I might have to start pushing for room for SPI drivers > in the SPL soon. :) As Andre already pointed out, I have a patch which adds boot support from SPI-NOR for D1/T113 SoCs. Maybe I can share it somewhere to avoid double work?

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-05-17 Thread Andre Przywara
On Wed, 17 May 2023 01:43:12 +0100 Andre Przywara wrote: +Maksim, as he was interested in the U-Boot series as well and had some plans for SPI-NOR booting, IIUC. Cheers, Andre > On Tue, 16 May 2023 17:53:38 -0600 > Sam Edwards wrote: > > Hi Sam, > > > On 5/16/23 15:08, Andre Przywara wrote:

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-05-16 Thread Sam Edwards
On 5/16/23 15:08, Andre Przywara wrote: This whole memory map is somewhat of a legacy. Apart from a few addresses for the SPL needs we shouldn't have those defines at all. Some symbols are needed because there are other macros using them, although these then are eventually unused. I have some

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-05-16 Thread Andre Przywara
On Tue, 16 May 2023 17:53:38 -0600 Sam Edwards wrote: Hi Sam, > On 5/16/23 15:08, Andre Przywara wrote: > > This whole memory map is somewhat of a legacy. Apart from a few > > addresses for the SPL needs we shouldn't have those defines at all. > > Some symbols are needed because there are other

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-05-16 Thread Andre Przywara
On Mon, 15 May 2023 20:32:52 -0600 Sam Edwards wrote: Hi Sam, > Hi Andre! Thank you for your efforts on this patchset; I've been > test-driving it a bit myself this week. many thanks for having a look, that's much appreciated! > On 12/5/22 17:45, Andre Przywara wrote: > > > +#define

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2023-05-16 Thread Sam Edwards
Hi Andre! Thank you for your efforts on this patchset; I've been test-driving it a bit myself this week. On 12/5/22 17:45, Andre Przywara wrote: +#define SUNXI_RTC_BASE 0x0700 +#define SUNXI_R_CPUCFG_BASE0x07000400 +#define SUNXI_PRCM_BASE

Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2022-12-05 Thread Icenowy Zheng
在 2022-12-06星期二的 00:45 +,Andre Przywara写道: > Allwinner seems to typically stick to a common MMIO memory map for > several SoCs, but from time to time does some breaking changes, which > also introduce new generations of some peripherals. The last time > this > happened with the H6, which apart

[RFC PATCH 08/17] sunxi: introduce NCAT2 generation model

2022-12-05 Thread Andre Przywara
Allwinner seems to typically stick to a common MMIO memory map for several SoCs, but from time to time does some breaking changes, which also introduce new generations of some peripherals. The last time this happened with the H6, which apart from re-organising the base addresses also changed the