Re: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-21 Thread Wolfgang Denk
Dear Peter Tyser, In message [EMAIL PROTECTED] you wrote: this text probably belongs in the commit message above your SOB. But I still don't understand why __TIME__ didn't work for you..can you elaborate? __TIME__ and __DATE__ aren't ideal as they are only updated when the file that

Re: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-21 Thread Peter Tyser
Hi Wolfgang, __TIME__ and __DATE__ aren't ideal as they are only updated when the file that contains them is recompiled. For example, during the normal modify/build/test cycle the version string remains the same for an 85xx board as start.S would not be recompiled. So any number of

Re: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-21 Thread Wolfgang Denk
Dear Peter Tyser, In message [EMAIL PROTECTED] you wrote: Actually the time stamp is completely useless in determining if the code is the same or different. I can compile the same code many times resulting in different time stamps and yet it's the very same code. The code won't be

Re: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-21 Thread Wolfgang Denk
Dear Jerry Van Baren, In message [EMAIL PROTECTED] you wrote: I know this patch isn't a big deal, but I think it would be a valuable change. If others don't agree I'll drop the issue. ... +1 Call me old fashioned, but I like time/date stamps. They are more meaningful to me as a quick

Re: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-21 Thread Andy Fleming
On Tue, Oct 21, 2008 at 9:59 AM, Wolfgang Denk [EMAIL PROTECTED] wrote: Dear Peter Tyser, Timestamps are not suitable to provide this type of information. If you care about which code you are running, than make sure to use git. I do, but the minor annoyance of having the exact same

Re: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-21 Thread Peter Tyser
Hi Andy, I don't think he's wanting this as much for releases (which would be fine with the git id as you mentioned), but during the development process. It is very useful during development to have a timestamp which confirms that what you are running now is what you expect. There are

Re: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-20 Thread Kim Phillips
On Fri, 17 Oct 2008 17:51:21 -0500 Peter Tyser [EMAIL PROTECTED] wrote: Use the GNU 'date' command to auto-generate a new U-Boot timestamp on every compile. Signed-off-by: Peter Tyser [EMAIL PROTECTED] --- I noticed that the build time of U-Boot was not updated on every compile which

[U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-17 Thread Peter Tyser
Use the GNU 'date' command to auto-generate a new U-Boot timestamp on every compile. Signed-off-by: Peter Tyser [EMAIL PROTECTED] --- I noticed that the build time of U-Boot was not updated on every compile which occassionally threw me for a loop as to whether a new U-Boot binary was programmed,

Re: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile

2008-10-17 Thread Peter Tyser
On Fri, 2008-10-17 at 17:51 -0500, Peter Tyser wrote: Use the GNU 'date' command to auto-generate a new U-Boot timestamp on every compile. Signed-off-by: Peter Tyser [EMAIL PROTECTED] --- I noticed that the build time of U-Boot was not updated on every compile which occassionally threw me