Re: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

2014-10-23 Thread Matthias Fuchs
Hi Valentin, On 10/14/2014 04:21 PM, Valentin Longchamp wrote: > Hi Matthias, > > On 10/14/2014 02:32 PM, Matthias Fuchs wrote: >> Hi Valentin, >> >> my patch fixed environment from i2c eeprom. I am not sure on which board >> I ran into that trouble. Probably PMC440. So reverting my former patch

Re: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

2014-10-23 Thread Tom Rini
On Thu, Oct 23, 2014 at 04:15:24PM +0200, Matthias Fuchs wrote: > Hi Valentin, > > On 10/14/2014 04:21 PM, Valentin Longchamp wrote: > > Hi Matthias, > > > > On 10/14/2014 02:32 PM, Matthias Fuchs wrote: > >> Hi Valentin, > >> > >> my patch fixed environment from i2c eeprom. I am not sure on whic

Re: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

2014-10-23 Thread Matthias Fuchs
Hi Valentin, On 10/14/2014 04:21 PM, Valentin Longchamp wrote: > Hi Matthias, > > On 10/14/2014 02:32 PM, Matthias Fuchs wrote: >> Hi Valentin, >> >> my patch fixed environment from i2c eeprom. I am not sure on which board >> I ran into that trouble. Probably PMC440. So reverting my former patch

Re: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

2014-10-14 Thread Valentin Longchamp
Hi Matthias, On 10/14/2014 02:32 PM, Matthias Fuchs wrote: > Hi Valentin, > > my patch fixed environment from i2c eeprom. I am not sure on which board > I ran into that trouble. Probably PMC440. So reverting my former patch > will break environment in i2c eeprom again on many boards. Good that y

Re: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

2014-10-14 Thread Matthias Fuchs
On 10/14/2014 03:01 PM, Holger Brunck wrote: > On 10/14/2014 02:32 PM, Matthias Fuchs wrote: >> Hi Valentin, >> >> my patch fixed environment from i2c eeprom. I am not sure on which board >> I ran into that trouble. Probably PMC440. So reverting my former patch >> will break environment in i2c eepr

Re: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

2014-10-14 Thread Holger Brunck
On 10/14/2014 02:32 PM, Matthias Fuchs wrote: > Hi Valentin, > > my patch fixed environment from i2c eeprom. I am not sure on which board > I ran into that trouble. Probably PMC440. So reverting my former patch > will break environment in i2c eeprom again on many boards. > > But perhaps there's a

Re: [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

2014-10-14 Thread Matthias Fuchs
Hi Valentin, my patch fixed environment from i2c eeprom. I am not sure on which board I ran into that trouble. Probably PMC440. So reverting my former patch will break environment in i2c eeprom again on many boards. But perhaps there's a better way to fix that. Matthias On 10/14/2014 11:16 AM,

[U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom"

2014-10-14 Thread Valentin Longchamp
Since i2c_init_all always sets the bus back to CONFIG_SYS_SPD_BUS_NUM for compatibility reasons, it means that any eeprom not located on this CONFIG_SYS_SPD_BUS_NUM is not accessible with the eeprom commands, even if you change the bus number with an i2c dev command before. Furthermore i2c_init_al