Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-16 Thread Tom Warren
Simon, > -Original Message- > From: Tom Warren > Sent: Wednesday, September 02, 2015 7:02 PM > To: 'Stephen Warren'; Simon Glass > Cc: U-Boot Mailing List; Thierry Reding; Tom Rini > Subject: RE: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64- >

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-16 Thread Tom Warren
Simon, > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Wednesday, September 16, 2015 6:11 PM > To: Tom Warren > Cc: U-Boot Mailing List; Thierry Reding; Tom Rini; Stephen Warren > Subject: Re: [U-Boot] [PATCH

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-16 Thread Simon Glass
5 4:44 PM >> > To: Tom Warren; Simon Glass >> > Cc: U-Boot Mailing List; Thierry Reding; Tom Rini >> > Subject: Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() >> > for 64- bit" >> > >> > On 09/02/2015 01:54 PM, Steph

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-02 Thread Simon Glass
eng >> Cc: Michal Suchanek; Tom Rini; Stephen Warren; U-Boot Mailing List; Tom >> Warren; Thierry Reding >> Subject: Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64- >> bit" >> >> Hi, >> > > > [snip] > >> >>

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-02 Thread Tom Warren
Subject: Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64- > bit" > > Hi, > [snip] > > I plan to apply this revert to u-boot-x86 (where SPI is currently > broken) and (once it has a bit more testing) also this patch which I th

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-02 Thread Stephen Warren
Cc: Bin Meng; Thierry Reding; Tom Rini; U-Boot Mailing List >>> Subject: Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for >>> 64- >>> bit" >>> >>> On 09/02/2015 09:52 AM, Tom Warren wrote: >>>> Simon, et al, >>&

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-02 Thread Tom Warren
> -Original Message- > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Wednesday, September 02, 2015 4:44 PM > To: Tom Warren; Simon Glass > Cc: U-Boot Mailing List; Thierry Reding; Tom Rini > Subject: Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_ad

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-02 Thread Stephen Warren
On 09/02/2015 09:52 AM, Tom Warren wrote: > Simon, et al, > >> Simon Glass wrote at Friday, August 14, 2015 3:05 AM: >> I plan to apply this revert to u-boot-x86 (where SPI is currently >> broken) and (once it has a bit more testing) also this patch which I think >> makes >> the change in a

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-02 Thread Tom Warren
> -Original Message- > From: Stephen Warren > Sent: Wednesday, September 02, 2015 1:05 PM > To: Tom Warren; Simon Glass > Cc: Bin Meng; Thierry Reding; Tom Rini; U-Boot Mailing List > Subject: Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64- &g

Re: [U-Boot] [PATCH] Revert "fdt: Fix fdtdec_get_addr_size() for 64-bit"

2015-09-02 Thread Stephen Warren
On 09/02/2015 01:39 PM, Tom Warren wrote: > > >> -Original Message- >> From: Stephen Warren >> Sent: Wednesday, September 02, 2015 1:05 PM >> To: Tom Warren; Simon Glass >> Cc: Bin Meng; Thierry Reding; Tom Rini; U-Boot Mailing List >> Subj

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Thierry Reding
On Fri, Aug 14, 2015 at 04:44:28PM +0800, Bin Meng wrote: Hi Thierry, On Fri, Aug 14, 2015 at 4:32 PM, Thierry Reding tred...@nvidia.com wrote: On Fri, Aug 14, 2015 at 04:10:32PM +0800, Bin Meng wrote: Hi, On Sun, Aug 9, 2015 at 11:08 PM, Simon Glass s...@chromium.org wrote: Hi

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Bin Meng
Hi Michal, On Fri, Aug 14, 2015 at 5:01 PM, Michal Suchanek hramr...@gmail.com wrote: On 14 August 2015 at 10:10, Bin Meng bmeng...@gmail.com wrote: Do we have any conclusion about commit 5b34436? Today I started to check the pre-relocatoin DM PCI UART issue, but found it is now broken due

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Bin Meng
Hi, On Sun, Aug 9, 2015 at 11:08 PM, Simon Glass s...@chromium.org wrote: Hi Stephen, On 6 August 2015 at 13:03, Stephen Warren swar...@wwwdotorg.org wrote: On 08/05/2015 05:45 PM, Simon Glass wrote: Hi Stephen, On 5 August 2015 at 12:22, Stephen Warren swar...@wwwdotorg.org wrote: On

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Thierry Reding
On Fri, Aug 14, 2015 at 04:10:32PM +0800, Bin Meng wrote: Hi, On Sun, Aug 9, 2015 at 11:08 PM, Simon Glass s...@chromium.org wrote: Hi Stephen, On 6 August 2015 at 13:03, Stephen Warren swar...@wwwdotorg.org wrote: On 08/05/2015 05:45 PM, Simon Glass wrote: Hi Stephen, On 5

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Bin Meng
Hi Thierry, On Fri, Aug 14, 2015 at 4:32 PM, Thierry Reding tred...@nvidia.com wrote: On Fri, Aug 14, 2015 at 04:10:32PM +0800, Bin Meng wrote: Hi, On Sun, Aug 9, 2015 at 11:08 PM, Simon Glass s...@chromium.org wrote: Hi Stephen, On 6 August 2015 at 13:03, Stephen Warren

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Michal Suchanek
On 14 August 2015 at 10:10, Bin Meng bmeng...@gmail.com wrote: Do we have any conclusion about commit 5b34436? Today I started to check the pre-relocatoin DM PCI UART issue, but found it is now broken due to this commit. The broken part is at ns16550_serial_ofdata_to_platdata() in

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Bin Meng
Hi Thierry, On Fri, Aug 14, 2015 at 10:06 PM, Thierry Reding tred...@nvidia.com wrote: On Fri, Aug 14, 2015 at 04:44:28PM +0800, Bin Meng wrote: Hi Thierry, On Fri, Aug 14, 2015 at 4:32 PM, Thierry Reding tred...@nvidia.com wrote: On Fri, Aug 14, 2015 at 04:10:32PM +0800, Bin Meng wrote:

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Simon Glass
On 6 August 2015 at 13:03, Stephen Warren swar...@wwwdotorg.org wrote: [snip] It turns out that arch/arm/include/asm/config.h already enables this for all ARM64 platforms. As such, we can in fact go ahead with reverting this patch, and U-Boot will still function on Tegra210 boards. Applied

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-14 Thread Simon Glass
Hi, On 14 August 2015 at 03:08, Bin Meng bmeng...@gmail.com wrote: Hi Michal, On Fri, Aug 14, 2015 at 5:01 PM, Michal Suchanek hramr...@gmail.com wrote: On 14 August 2015 at 10:10, Bin Meng bmeng...@gmail.com wrote: Do we have any conclusion about commit 5b34436? Today I started to check

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-09 Thread Simon Glass
Hi Stephen, On 6 August 2015 at 13:03, Stephen Warren swar...@wwwdotorg.org wrote: On 08/05/2015 05:45 PM, Simon Glass wrote: Hi Stephen, On 5 August 2015 at 12:22, Stephen Warren swar...@wwwdotorg.org wrote: On 08/04/2015 10:08 PM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-06 Thread Michal Suchanek
Hello, On 6 August 2015 at 01:45, Simon Glass s...@chromium.org wrote: Hi Stephen, On 5 August 2015 at 12:22, Stephen Warren swar...@wwwdotorg.org wrote: On 08/04/2015 10:08 PM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 12:20, Stephen Warren swar...@wwwdotorg.org wrote: On

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-06 Thread Stephen Warren
On 08/06/2015 01:09 AM, Michal Suchanek wrote: Hello, On 6 August 2015 at 01:45, Simon Glass s...@chromium.org wrote: Hi Stephen, On 5 August 2015 at 12:22, Stephen Warren swar...@wwwdotorg.org wrote: On 08/04/2015 10:08 PM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 12:20,

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-06 Thread Stephen Warren
On 08/05/2015 05:45 PM, Simon Glass wrote: Hi Stephen, On 5 August 2015 at 12:22, Stephen Warren swar...@wwwdotorg.org wrote: On 08/04/2015 10:08 PM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 12:20, Stephen Warren swar...@wwwdotorg.org wrote: On 08/03/2015 09:52 AM, Simon Glass

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-05 Thread Stephen Warren
On 08/04/2015 10:08 PM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 12:20, Stephen Warren swar...@wwwdotorg.org wrote: On 08/03/2015 09:52 AM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 09:12, Stephen Warren swar...@wwwdotorg.org wrote: On 08/02/2015 06:13 PM, Simon Glass

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-05 Thread Simon Glass
Hi Stephen, On 5 August 2015 at 12:22, Stephen Warren swar...@wwwdotorg.org wrote: On 08/04/2015 10:08 PM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 12:20, Stephen Warren swar...@wwwdotorg.org wrote: On 08/03/2015 09:52 AM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-04 Thread Thierry Reding
On Sun, Aug 02, 2015 at 06:13:50PM -0600, Simon Glass wrote: This reverts commit 5b34436035fc862b5e8d0d2c3eab74ba36f1a7f4. This function has a few problems. It calls fdt_parent_offset() which as mentioned in code review is very slow. https://patchwork.ozlabs.org/patch/499482/

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-04 Thread Simon Glass
Hi Stephen, On 3 August 2015 at 12:20, Stephen Warren swar...@wwwdotorg.org wrote: On 08/03/2015 09:52 AM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 09:12, Stephen Warren swar...@wwwdotorg.org wrote: On 08/02/2015 06:13 PM, Simon Glass wrote: This reverts commit

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-03 Thread Simon Glass
Hi Stephen, On 3 August 2015 at 09:12, Stephen Warren swar...@wwwdotorg.org wrote: On 08/02/2015 06:13 PM, Simon Glass wrote: This reverts commit 5b34436035fc862b5e8d0d2c3eab74ba36f1a7f4. This function has a few problems. It calls fdt_parent_offset() which as mentioned in code review is

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-03 Thread Bin Meng
Hi Simon, On Mon, Aug 3, 2015 at 8:13 AM, Simon Glass s...@chromium.org wrote: This reverts commit 5b34436035fc862b5e8d0d2c3eab74ba36f1a7f4. This function has a few problems. It calls fdt_parent_offset() which as mentioned in code review is very slow.

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-03 Thread Stephen Warren
On 08/02/2015 06:13 PM, Simon Glass wrote: This reverts commit 5b34436035fc862b5e8d0d2c3eab74ba36f1a7f4. This function has a few problems. It calls fdt_parent_offset() which as mentioned in code review is very slow. https://patchwork.ozlabs.org/patch/499482/

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-03 Thread Stephen Warren
On 08/03/2015 09:52 AM, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 09:12, Stephen Warren swar...@wwwdotorg.org wrote: On 08/02/2015 06:13 PM, Simon Glass wrote: This reverts commit 5b34436035fc862b5e8d0d2c3eab74ba36f1a7f4. This function has a few problems. It calls

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-03 Thread Tom Rini
On Mon, Aug 03, 2015 at 09:52:50AM -0600, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 09:12, Stephen Warren swar...@wwwdotorg.org wrote: On 08/02/2015 06:13 PM, Simon Glass wrote: This reverts commit 5b34436035fc862b5e8d0d2c3eab74ba36f1a7f4. This function has a few problems.

Re: [U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-03 Thread Simon Glass
Hi Tom. On 3 August 2015 at 11:25, Tom Rini tr...@konsulko.com wrote: On Mon, Aug 03, 2015 at 09:52:50AM -0600, Simon Glass wrote: Hi Stephen, On 3 August 2015 at 09:12, Stephen Warren swar...@wwwdotorg.org wrote: On 08/02/2015 06:13 PM, Simon Glass wrote: This reverts commit

[U-Boot] [PATCH] Revert fdt: Fix fdtdec_get_addr_size() for 64-bit

2015-08-02 Thread Simon Glass
This reverts commit 5b34436035fc862b5e8d0d2c3eab74ba36f1a7f4. This function has a few problems. It calls fdt_parent_offset() which as mentioned in code review is very slow. https://patchwork.ozlabs.org/patch/499482/ https://patchwork.ozlabs.org/patch/452604/ It also happens to break SPI flash