Re: [U-Boot] [PATCH] cfi_flash: Make all flash access functions weak

2008-11-17 Thread Stefan Roese
On Thursday 13 November 2008, Haavard Skinnemoen wrote: Stefan Roese [EMAIL PROTECTED] wrote: This patch defines all flash access functions as weak so that they can be overridden by board specific versions. This will be used by the upcoming VCTH board support where the NOR FLASH

Re: [U-Boot] [PATCH] cfi_flash: Make all flash access functions weak

2008-11-17 Thread Stefan Roese
On Monday 17 November 2008, Stefan Roese wrote: Old version without weak aliases: textdata bss dec hex filename 280964 20232 50788 351984 55ef0 ./u-boot New version with weak aliases: textdata bss dec hex filename 280520 20232 50788 351540

Re: [U-Boot] [PATCH] cfi_flash: Make all flash access functions weak

2008-11-17 Thread Haavard Skinnemoen
Stefan Roese [EMAIL PROTECTED] wrote: Old version without weak aliases: textdata bss dec hex filename 280964 20232 50788 351984 55ef0 ./u-boot New version with weak aliases: textdata bss dec hex filename 280520 20232 50788 351540 55d34

Re: [U-Boot] [PATCH] cfi_flash: Make all flash access functions weak

2008-11-17 Thread Stefan Roese
On Monday 17 November 2008, Haavard Skinnemoen wrote: Stefan Roese [EMAIL PROTECTED] wrote: Old version without weak aliases: textdata bss dec hex filename 280964 20232 50788 351984 55ef0 ./u-boot New version with weak aliases: textdata bss

Re: [U-Boot] [PATCH] cfi_flash: Make all flash access functions weak

2008-11-17 Thread Haavard Skinnemoen
Stefan Roese [EMAIL PROTECTED] wrote: I could do it this way, sure. But how about this version: static void __flash_write8(u8 value, void *addr) { __raw_writeb(value, addr); } ... #ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS void flash_write8(u8 value, void

Re: [U-Boot] [PATCH] cfi_flash: Make all flash access functions weak

2008-11-17 Thread Stefan Roese
On Monday 17 November 2008, Haavard Skinnemoen wrote: Stefan Roese [EMAIL PROTECTED] wrote: I could do it this way, sure. But how about this version: static void __flash_write8(u8 value, void *addr) { __raw_writeb(value, addr); } ... #ifdef

[U-Boot] [PATCH] cfi_flash: Make all flash access functions weak

2008-11-12 Thread Stefan Roese
This patch defines all flash access functions as weak so that they can be overridden by board specific versions. This will be used by the upcoming VCTH board support where the NOR FLASH unfortunately can't be accessed memory-mapped. Special accessor functions are needed here. Signed-off-by: