Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-29 Thread Scott Wood
On 10/28/2012 12:04:06 PM, Vikram Narayanan wrote: On 10/24/2012 10:41 PM, Scott Wood wrote: On 10/23/2012 11:14:34 PM, Vikram Narayanan wrote: On 10/24/2012 7:22 AM, Scott Wood wrote: On 10/23/2012 12:15:11 PM, Vikram Narayanan wrote: On 10/23/2012 9:15 PM, Tom Rini wrote: On Tue, Oct 23,

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-29 Thread Vikram Narayanan
On 10/29/2012 10:04 PM, Scott Wood wrote: It's not worth arguing over a single line of code that isn't going to cause any significant change. That would save us both some time. So you're withdrawing the patch? Yes. I'm more concerned about the precedent it sets than the one specific line.

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-28 Thread Vikram Narayanan
On 10/24/2012 10:41 PM, Scott Wood wrote: On 10/23/2012 11:14:34 PM, Vikram Narayanan wrote: On 10/24/2012 7:22 AM, Scott Wood wrote: On 10/23/2012 12:15:11 PM, Vikram Narayanan wrote: On 10/23/2012 9:15 PM, Tom Rini wrote: On Tue, Oct 23, 2012 at 12:26:53PM +0200, Stefan Roese wrote: On

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-24 Thread Scott Wood
On 10/23/2012 11:14:34 PM, Vikram Narayanan wrote: On 10/24/2012 7:22 AM, Scott Wood wrote: On 10/23/2012 12:15:11 PM, Vikram Narayanan wrote: On 10/23/2012 9:15 PM, Tom Rini wrote: On Tue, Oct 23, 2012 at 12:26:53PM +0200, Stefan Roese wrote: On 10/23/2012 12:05 PM, Vikram Narayanan wrote:

[U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-23 Thread Vikram Narayanan
As dummy{1,2} are not used anywhere, mark it with __maybe_unused Signed-off-by: Vikram Narayanan vikram...@gmail.com Cc: Stefan Roese s...@denx.de --- common/spl/spl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-23 Thread Stefan Roese
On 10/23/2012 12:05 PM, Vikram Narayanan wrote: As dummy{1,2} are not used anywhere, mark it with __maybe_unused Signed-off-by: Vikram Narayanan vikram...@gmail.com Cc: Stefan Roese s...@denx.de --- common/spl/spl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-23 Thread Vikram Narayanan
On 10/23/2012 3:56 PM, Stefan Roese wrote: On 10/23/2012 12:05 PM, Vikram Narayanan wrote: As dummy{1,2} are not used anywhere, mark it with __maybe_unused Signed-off-by: Vikram Narayananvikram...@gmail.com Cc: Stefan Roeses...@denx.de --- common/spl/spl.c |2 +- 1 files changed, 1

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-23 Thread Tom Rini
On Tue, Oct 23, 2012 at 12:26:53PM +0200, Stefan Roese wrote: On 10/23/2012 12:05 PM, Vikram Narayanan wrote: As dummy{1,2} are not used anywhere, mark it with __maybe_unused Signed-off-by: Vikram Narayanan vikram...@gmail.com Cc: Stefan Roese s...@denx.de --- common/spl/spl.c |2

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-23 Thread Vikram Narayanan
On 10/23/2012 9:15 PM, Tom Rini wrote: On Tue, Oct 23, 2012 at 12:26:53PM +0200, Stefan Roese wrote: On 10/23/2012 12:05 PM, Vikram Narayanan wrote: As dummy{1,2} are not used anywhere, mark it with __maybe_unused Signed-off-by: Vikram Narayananvikram...@gmail.com Cc: Stefan Roeses...@denx.de

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-23 Thread Scott Wood
On 10/23/2012 12:15:11 PM, Vikram Narayanan wrote: On 10/23/2012 9:15 PM, Tom Rini wrote: On Tue, Oct 23, 2012 at 12:26:53PM +0200, Stefan Roese wrote: On 10/23/2012 12:05 PM, Vikram Narayanan wrote: As dummy{1,2} are not used anywhere, mark it with __maybe_unused Signed-off-by: Vikram

Re: [U-Boot] [PATCH] common/spl: Mark arguments as unused

2012-10-23 Thread Vikram Narayanan
On 10/24/2012 7:22 AM, Scott Wood wrote: On 10/23/2012 12:15:11 PM, Vikram Narayanan wrote: On 10/23/2012 9:15 PM, Tom Rini wrote: On Tue, Oct 23, 2012 at 12:26:53PM +0200, Stefan Roese wrote: On 10/23/2012 12:05 PM, Vikram Narayanan wrote: As dummy{1,2} are not used anywhere, mark it with