Re: [U-Boot] [PATCH] core: of_addr: Correct the size type of of_get_address to fdt_size_t

2019-09-16 Thread Simon Glass
Hi, On Mon, 26 Aug 2019 at 11:16, Eugeniu Rosca wrote: > > Hi Keerthy, > Hi Simon, > cc: Tom > > On Tue, Aug 20, 2019 at 09:39:32AM +0530, Keerthy wrote: > > On 19/08/19 3:54 PM, Eugeniu Rosca wrote: > [..] > > > I took some time to also review the changes in addition to testing. > > > > > > I

Re: [U-Boot] [PATCH] core: of_addr: Correct the size type of of_get_address to fdt_size_t

2019-08-26 Thread Eugeniu Rosca
Hi Keerthy, Hi Simon, cc: Tom On Tue, Aug 20, 2019 at 09:39:32AM +0530, Keerthy wrote: > On 19/08/19 3:54 PM, Eugeniu Rosca wrote: [..] > > I took some time to also review the changes in addition to testing. > > > > I can see that, since its inception in Linux [1], of_get_address() used > >

Re: [U-Boot] [PATCH] core: of_addr: Correct the size type of of_get_address to fdt_size_t

2019-08-19 Thread Keerthy
On 19/08/19 3:54 PM, Eugeniu Rosca wrote: Hi Keerthy, On Wed, Aug 14, 2019 at 03:56:48PM +0530, Keerthy wrote: Currently the size parameter is defined as u64 type. Correct the size type of of_get_address to fdt_size_t so that both 64 bit and 32 bit architectures are taken care of. The

Re: [U-Boot] [PATCH] core: of_addr: Correct the size type of of_get_address to fdt_size_t

2019-08-19 Thread Eugeniu Rosca
Hi Keerthy, On Wed, Aug 14, 2019 at 03:56:48PM +0530, Keerthy wrote: > Currently the size parameter is defined as u64 type. > Correct the size type of of_get_address to fdt_size_t > so that both 64 bit and 32 bit architectures are taken > care of. > > The initial bug report: >

[U-Boot] [PATCH] core: of_addr: Correct the size type of of_get_address to fdt_size_t

2019-08-14 Thread Keerthy
Currently the size parameter is defined as u64 type. Correct the size type of of_get_address to fdt_size_t so that both 64 bit and 32 bit architectures are taken care of. The initial bug report: https://patchwork.ozlabs.org/patch/1090094/#2212555 Fixes: e679d03b08fb ("core: ofnode: Add