Re: [U-Boot] [PATCH] davinci: Enable DDR_INIT for DRA8XX

2018-03-16 Thread Lokesh Vutla 


On Friday 16 March 2018 02:16 PM, Tero Kristo wrote:
> On 16/03/18 10:32, Lokesh Vutla wrote:
>> Commit 6aa4ad8e3820 ("Convert CONFIG_SOC_DA8XX et al to Kconfig")
>> converted SOC_DRA8XX to Kconfig but missed enabling DDR_INIT for
>> SOC_DRA8XX, which broke OMAPL138 to boot.
>>
>> Commit 2e87980580d0 ("davinci: Fix omapl138_lcdk builds") disabled
>> DDR_INIT for all DA850 SoCs. This failed all DRA850 boards to boot
>> as ddr is not being initialized.
>>
>> Enable SYS_DA850_DDR_INIT for DRA8XX so that all DRA850 and OMAPL138
>> will have ddr initialized
> 
> You have typoed the soc names above, all DRA8xx refs should be DA8xx
> instead.

Oops. Will resend the patch.

Thanks and regards,
Lokesh

> 
> -Tero
> 
>>
>> Fixes: 2e87980580d0 ("davinci: Fix omapl138_lcdk builds")
>> Fixes: 6aa4ad8e3820 ("Convert CONFIG_SOC_DA8XX et al to Kconfig")
>> Reported-by: Sekhar Nori 
>> Tested-by: Sekhar Nori 
>> Signed-off-by: Lokesh Vutla 
>> ---
>>   arch/arm/mach-davinci/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-davinci/Kconfig
>> b/arch/arm/mach-davinci/Kconfig
>> index 30752839a3..5e7baba3fe 100644
>> --- a/arch/arm/mach-davinci/Kconfig
>> +++ b/arch/arm/mach-davinci/Kconfig
>> @@ -58,6 +58,7 @@ config SOC_DA850
>>   config SOC_DA8XX
>>   bool
>>   select SYS_DA850_PLL_INIT if SUPPORT_SPL || DA850_LOWLEVEL
>> +    select SYS_DA850_DDR_INIT if SUPPORT_SPL || DA850_LOWLEVEL
>>     config MACH_DAVINCI_DA850_EVM
>>   bool
>>
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] davinci: Enable DDR_INIT for DRA8XX

2018-03-16 Thread Tero Kristo 

On 16/03/18 10:32, Lokesh Vutla wrote:

Commit 6aa4ad8e3820 ("Convert CONFIG_SOC_DA8XX et al to Kconfig")
converted SOC_DRA8XX to Kconfig but missed enabling DDR_INIT for
SOC_DRA8XX, which broke OMAPL138 to boot.

Commit 2e87980580d0 ("davinci: Fix omapl138_lcdk builds") disabled
DDR_INIT for all DA850 SoCs. This failed all DRA850 boards to boot
as ddr is not being initialized.

Enable SYS_DA850_DDR_INIT for DRA8XX so that all DRA850 and OMAPL138
will have ddr initialized


You have typoed the soc names above, all DRA8xx refs should be DA8xx 
instead.


-Tero



Fixes: 2e87980580d0 ("davinci: Fix omapl138_lcdk builds")
Fixes: 6aa4ad8e3820 ("Convert CONFIG_SOC_DA8XX et al to Kconfig")
Reported-by: Sekhar Nori 
Tested-by: Sekhar Nori 
Signed-off-by: Lokesh Vutla 
---
  arch/arm/mach-davinci/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 30752839a3..5e7baba3fe 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -58,6 +58,7 @@ config SOC_DA850
  config SOC_DA8XX
bool
select SYS_DA850_PLL_INIT if SUPPORT_SPL || DA850_LOWLEVEL
+   select SYS_DA850_DDR_INIT if SUPPORT_SPL || DA850_LOWLEVEL
  
  config MACH_DAVINCI_DA850_EVM

bool



--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] davinci: Enable DDR_INIT for DRA8XX

2018-03-16 Thread Lokesh Vutla 
Commit 6aa4ad8e3820 ("Convert CONFIG_SOC_DA8XX et al to Kconfig")
converted SOC_DRA8XX to Kconfig but missed enabling DDR_INIT for
SOC_DRA8XX, which broke OMAPL138 to boot.

Commit 2e87980580d0 ("davinci: Fix omapl138_lcdk builds") disabled
DDR_INIT for all DA850 SoCs. This failed all DRA850 boards to boot
as ddr is not being initialized.

Enable SYS_DA850_DDR_INIT for DRA8XX so that all DRA850 and OMAPL138
will have ddr initialized

Fixes: 2e87980580d0 ("davinci: Fix omapl138_lcdk builds")
Fixes: 6aa4ad8e3820 ("Convert CONFIG_SOC_DA8XX et al to Kconfig")
Reported-by: Sekhar Nori 
Tested-by: Sekhar Nori 
Signed-off-by: Lokesh Vutla 
---
 arch/arm/mach-davinci/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 30752839a3..5e7baba3fe 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -58,6 +58,7 @@ config SOC_DA850
 config SOC_DA8XX
bool
select SYS_DA850_PLL_INIT if SUPPORT_SPL || DA850_LOWLEVEL
+   select SYS_DA850_DDR_INIT if SUPPORT_SPL || DA850_LOWLEVEL
 
 config MACH_DAVINCI_DA850_EVM
bool
-- 
2.16.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot