Re: [U-Boot] [PATCH] dfu: Handle large transfers correctly

2012-11-29 Thread Lukasz Majewski
Hi Pantelis, The sequence number is a 16 bit counter; make sure we handle rollover correctly. This fixes the wrong transfers for large ( 256MB) images. This is a bit misleading comment. DFU 1.1 standard says: The wBlockNum field is a block sequence number. It increments each time a block is

Re: [U-Boot] [PATCH] dfu: Handle large transfers correctly

2012-11-29 Thread Pantelis Antoniou
Hi Lukasz, On Nov 29, 2012, at 11:06 AM, Lukasz Majewski wrote: Hi Pantelis, The sequence number is a 16 bit counter; make sure we handle rollover correctly. This fixes the wrong transfers for large ( 256MB) images. This is a bit misleading comment. DFU 1.1 standard says: The

Re: [U-Boot] [PATCH] dfu: Handle large transfers correctly

2012-11-29 Thread Lukasz Majewski
Hi Pantelis, Please see below comments. Moreover this patch doesn't solve the problem of bricking trats board after flashing it with dfu after applying: [U-Boot] [PATCH] dfu: Handle large transfers correctly on top of: [U-Boot] [PATCH 00/10] USB: Gadget DFU related fixes Without your patches

[U-Boot] [PATCH] dfu: Handle large transfers correctly (take #2)

2012-11-29 Thread Pantelis Antoniou
The sequence number is a 16 bit counter; make sure we handle rollover correctly. This fixes the wrong transfers for large ( 256MB) images. Also utilize a variable to handle initialization, so that we don't rely on just the counter sent by the host. Signed-off-by: Pantelis Antoniou

Re: [U-Boot] [PATCH] dfu: Handle large transfers correctly (take #2)

2012-11-29 Thread Marek Vasut
Dear Pantelis Antoniou, The sequence number is a 16 bit counter; make sure we handle rollover correctly. This fixes the wrong transfers for large ( 256MB) images. Also utilize a variable to handle initialization, so that we don't rely on just the counter sent by the host. [...] Uh, how

[U-Boot] [PATCH] dfu: Handle large transfers correctly

2012-11-28 Thread Pantelis Antoniou
The sequence number is a 16 bit counter; make sure we handle rollover correctly. This fixes the wrong transfers for large ( 256MB) images. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/dfu/dfu.c | 28 +++- drivers/dfu/dfu_mmc.c | 3 +++

Re: [U-Boot] [PATCH] dfu: Handle large transfers correctly

2012-11-28 Thread Marek Vasut
Dear Pantelis Antoniou, The sequence number is a 16 bit counter; make sure we handle rollover correctly. This fixes the wrong transfers for large ( 256MB) images. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/dfu/dfu.c | 28 +++-