Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-03-17 Thread Lukasz Majewski
Hi Lukasz, For some time we have been using the run_command() with properly crafted string. Such approach turned to be unreliable and error prone. Switch to native mmc subsystem API would allow better type checking and shall improve speed. Also, it seems that this API is changing less

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-03-12 Thread Lukasz Majewski
Hi Tom, Pantelis Hi Lukasz, On Feb 27, 2014, at 11:21 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, Looks fine to me. Let me run a few tests over the weekend and I'll apply.

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-03-12 Thread Pantelis Antoniou
Hi Lukasz, On Mar 12, 2014, at 10:06 AM, Lukasz Majewski wrote: Hi Tom, Pantelis Hi Lukasz, On Feb 27, 2014, at 11:21 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, Looks fine to me. Let

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-03-12 Thread Lukasz Majewski
Hi Pantelis, Tom, Hi Lukasz, On Mar 12, 2014, at 10:06 AM, Lukasz Majewski wrote: Hi Tom, Pantelis Hi Lukasz, On Feb 27, 2014, at 11:21 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM, Lukasz Majewski wrote: Hi Pantelis,

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-03-12 Thread Pantelis Antoniou
On Mar 12, 2014, at 1:12 PM, Lukasz Majewski wrote: Hi Pantelis, Tom, Hi Lukasz, On Mar 12, 2014, at 10:06 AM, Lukasz Majewski wrote: Hi Tom, Pantelis Hi Lukasz, On Feb 27, 2014, at 11:21 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM,

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-03-06 Thread Lukasz Majewski
Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 11:21 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, Looks fine to me. Let me run a few tests over the weekend and I'll apply.

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-02-27 Thread Lukasz Majewski
Hi Pantelis, Hi Lukasz, Looks fine to me. Let me run a few tests over the weekend and I'll apply. Have the run test gone smoothly? Thanks -- Pantelis On Feb 21, 2014, at 9:23 AM, Lukasz Majewski wrote: For some time we have been using the run_command() with properly crafted

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-02-27 Thread Pantelis Antoniou
Hi Lukasz, On Feb 27, 2014, at 10:36 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, Looks fine to me. Let me run a few tests over the weekend and I'll apply. Have the run test gone smoothly? In the middle of reworking some core stuff in mmc, will test when that's done.

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-02-27 Thread Lukasz Majewski
Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, Looks fine to me. Let me run a few tests over the weekend and I'll apply. Have the run test gone smoothly? In the middle of reworking some core stuff in mmc, will

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-02-27 Thread Pantelis Antoniou
Hi Lukasz, On Feb 27, 2014, at 11:21 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, Looks fine to me. Let me run a few tests over the weekend and I'll apply. Have the run test gone smoothly?

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-02-22 Thread Lukasz Majewski
Hi Pantelis, Hi Lukasz, Looks fine to me. Let me run a few tests over the weekend I was wondering if we could share tests for DFU? Will it be suitable to put it in the ./test/dfu? and I'll apply. Thanks -- Pantelis On Feb 21, 2014, at 9:23 AM, Lukasz Majewski wrote:

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-02-21 Thread Pantelis Antoniou
Hi Lukasz, Looks fine to me. Let me run a few tests over the weekend and I'll apply. Thanks -- Pantelis On Feb 21, 2014, at 9:23 AM, Lukasz Majewski wrote: For some time we have been using the run_command() with properly crafted string. Such approach turned to be unreliable and error

[U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-02-20 Thread Lukasz Majewski
For some time we have been using the run_command() with properly crafted string. Such approach turned to be unreliable and error prone. Switch to native mmc subsystem API would allow better type checking and shall improve speed. Also, it seems that this API is changing less often than u-boot