Re: [U-Boot] [PATCH] i2c_eeprom: include linux/err.h to fix build error

2014-12-29 Thread Simon Glass
On 18 December 2014 at 06:18, Simon Glass s...@chromium.org wrote:
 On 18 December 2014 at 04:00, Masahiro Yamada yamad...@jp.panasonic.com 
 wrote:
 drivers/misc/i2c_eeprom.c fails to build unless CONFIG_FIT_SIGNATURE
 is defined.

   CC  drivers/misc/i2c_eeprom.o
 drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_read':
 drivers/misc/i2c_eeprom.c:15:10: error: 'ENODEV' undeclared
 (first use in this function)
 drivers/misc/i2c_eeprom.c:15:10: note: each undeclared identifier
 is reported only once for each function it appears in
 drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_write':
 drivers/misc/i2c_eeprom.c:21:10: error: 'ENODEV' undeclared
 (first use in this function)
 drivers/misc/i2c_eeprom.c:22:1: warning: control reaches end of
 non-void function [-Wreturn-type]
 drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_read':
 drivers/misc/i2c_eeprom.c:16:1: warning: control reaches end of
 non-void function [-Wreturn-type]
 make[2]: *** [drivers/misc/i2c_eeprom.o] Error 1
 make[1]: *** [drivers/misc] Error 2
 make: *** [drivers] Error 2

 By the way, Sandbox (enabling CONFIG_FIT_SIGNATURE) is luckily
 working depending on it.
 Sandbox includes include/asm-generic/errno.h
 from include/errno.h
 from include/u-boot/rsa-checksum.h
 from include/image.h
 from include/common.h
 from drivers/misc/i2c_eeprom.c

 Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com
 ---

  drivers/misc/i2c_eeprom.c | 1 +
  1 file changed, 1 insertion(+)

 Thanks!

 Acked-by: Simon Glass s...@chromium.org

Applied to u-boot-x86 branch misc.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] i2c_eeprom: include linux/err.h to fix build error

2014-12-18 Thread Masahiro Yamada
drivers/misc/i2c_eeprom.c fails to build unless CONFIG_FIT_SIGNATURE
is defined.

  CC  drivers/misc/i2c_eeprom.o
drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_read':
drivers/misc/i2c_eeprom.c:15:10: error: 'ENODEV' undeclared
(first use in this function)
drivers/misc/i2c_eeprom.c:15:10: note: each undeclared identifier
is reported only once for each function it appears in
drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_write':
drivers/misc/i2c_eeprom.c:21:10: error: 'ENODEV' undeclared
(first use in this function)
drivers/misc/i2c_eeprom.c:22:1: warning: control reaches end of
non-void function [-Wreturn-type]
drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_read':
drivers/misc/i2c_eeprom.c:16:1: warning: control reaches end of
non-void function [-Wreturn-type]
make[2]: *** [drivers/misc/i2c_eeprom.o] Error 1
make[1]: *** [drivers/misc] Error 2
make: *** [drivers] Error 2

By the way, Sandbox (enabling CONFIG_FIT_SIGNATURE) is luckily
working depending on it.
Sandbox includes include/asm-generic/errno.h
from include/errno.h
from include/u-boot/rsa-checksum.h
from include/image.h
from include/common.h
from drivers/misc/i2c_eeprom.c

Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com
---

 drivers/misc/i2c_eeprom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c
index d0548ec..814134a 100644
--- a/drivers/misc/i2c_eeprom.c
+++ b/drivers/misc/i2c_eeprom.c
@@ -5,6 +5,7 @@
  */
 
 #include common.h
+#include linux/err.h
 #include dm.h
 #include i2c.h
 #include i2c_eeprom.h
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] i2c_eeprom: include linux/err.h to fix build error

2014-12-18 Thread Simon Glass
On 18 December 2014 at 04:00, Masahiro Yamada yamad...@jp.panasonic.com wrote:
 drivers/misc/i2c_eeprom.c fails to build unless CONFIG_FIT_SIGNATURE
 is defined.

   CC  drivers/misc/i2c_eeprom.o
 drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_read':
 drivers/misc/i2c_eeprom.c:15:10: error: 'ENODEV' undeclared
 (first use in this function)
 drivers/misc/i2c_eeprom.c:15:10: note: each undeclared identifier
 is reported only once for each function it appears in
 drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_write':
 drivers/misc/i2c_eeprom.c:21:10: error: 'ENODEV' undeclared
 (first use in this function)
 drivers/misc/i2c_eeprom.c:22:1: warning: control reaches end of
 non-void function [-Wreturn-type]
 drivers/misc/i2c_eeprom.c: In function 'i2c_eeprom_read':
 drivers/misc/i2c_eeprom.c:16:1: warning: control reaches end of
 non-void function [-Wreturn-type]
 make[2]: *** [drivers/misc/i2c_eeprom.o] Error 1
 make[1]: *** [drivers/misc] Error 2
 make: *** [drivers] Error 2

 By the way, Sandbox (enabling CONFIG_FIT_SIGNATURE) is luckily
 working depending on it.
 Sandbox includes include/asm-generic/errno.h
 from include/errno.h
 from include/u-boot/rsa-checksum.h
 from include/image.h
 from include/common.h
 from drivers/misc/i2c_eeprom.c

 Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com
 ---

  drivers/misc/i2c_eeprom.c | 1 +
  1 file changed, 1 insertion(+)

Thanks!

Acked-by: Simon Glass s...@chromium.org

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot