Re: [U-Boot] [PATCH] lan7xxx: Require phylib
On Thu, Mar 15, 2018 at 10:16 PM, Tuomas Tynkkynenwrote: > Hi, > > On Thu, 15 Mar 2018 15:10:20 +0100 > Alexander Graf wrote: > >> The lan75xx and lan78xx drivers need to drive their phy via the generic >> phylib framework. Let's reflect that dependency in Kconfig, so that we >> don't get build errors when phylib does not get selected. >> >> Signed-off-by: Alexander Graf >> --- >> drivers/usb/eth/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/usb/eth/Kconfig b/drivers/usb/eth/Kconfig >> index 496a6d1933..2f6bfa8e71 100644 >> --- a/drivers/usb/eth/Kconfig >> +++ b/drivers/usb/eth/Kconfig >> @@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179 >> config USB_ETHER_LAN75XX >> bool "Microchip LAN75XX support" >> depends on USB_HOST_ETHER >> + depends on PHYLIB > > 'select PHYLIB' seems more appropriate here (and there are already 17 > drivers selecting it and none using 'depends on'.) Yeah, good point. Please change this. Thanks, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] lan7xxx: Require phylib
Hi, On Thu, 15 Mar 2018 15:10:20 +0100 Alexander Grafwrote: > The lan75xx and lan78xx drivers need to drive their phy via the generic > phylib framework. Let's reflect that dependency in Kconfig, so that we > don't get build errors when phylib does not get selected. > > Signed-off-by: Alexander Graf > --- > drivers/usb/eth/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/eth/Kconfig b/drivers/usb/eth/Kconfig > index 496a6d1933..2f6bfa8e71 100644 > --- a/drivers/usb/eth/Kconfig > +++ b/drivers/usb/eth/Kconfig > @@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179 > config USB_ETHER_LAN75XX > bool "Microchip LAN75XX support" > depends on USB_HOST_ETHER > + depends on PHYLIB 'select PHYLIB' seems more appropriate here (and there are already 17 drivers selecting it and none using 'depends on'.) ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] lan7xxx: Require phylib
On Thu, Mar 15, 2018 at 9:10 AM, Alexander Grafwrote: > The lan75xx and lan78xx drivers need to drive their phy via the generic > phylib framework. Let's reflect that dependency in Kconfig, so that we > don't get build errors when phylib does not get selected. > > Signed-off-by: Alexander Graf Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] lan7xxx: Require phylib
The lan75xx and lan78xx drivers need to drive their phy via the generic phylib framework. Let's reflect that dependency in Kconfig, so that we don't get build errors when phylib does not get selected. Signed-off-by: Alexander Graf--- drivers/usb/eth/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/eth/Kconfig b/drivers/usb/eth/Kconfig index 496a6d1933..2f6bfa8e71 100644 --- a/drivers/usb/eth/Kconfig +++ b/drivers/usb/eth/Kconfig @@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179 config USB_ETHER_LAN75XX bool "Microchip LAN75XX support" depends on USB_HOST_ETHER + depends on PHYLIB ---help--- Say Y here if you would like to support Microchip LAN75XX Hi-Speed USB 2.0 to 10/100/1000 Gigabit Ethernet controller. @@ -32,6 +33,7 @@ config USB_ETHER_LAN75XX config USB_ETHER_LAN78XX bool "Microchip LAN78XX support" depends on USB_HOST_ETHER + depends on PHYLIB ---help--- Say Y here if you would like to support Microchip LAN78XX USB 3.1 Gen 1 to 10/100/1000 Gigabit Ethernet controller. -- 2.12.3 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot