Re: [U-Boot] [PATCH] lib: Makefile: build fdtdec_common.c when OF_LIBFDT selected

2019-06-05 Thread Peng Fan 
> Subject: Re: [PATCH] lib: Makefile: build fdtdec_common.c when OF_LIBFDT
> selected
> 
> On 5/31/19 5:11 AM, Peng Fan wrote:
> > When build SPL_OF_PLATDATA on i.MX6, meet issue the fdtdec_get_int not
> > defined, however fdtdec.c will use fdtdec_get_int, so let's compile
> > fdtdec_common.c when OF_LIBFDT selected.
> >
> > Signed-off-by: Peng Fan 
> > ---
> >   lib/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile index 09c45b8122..66ab6295a5
> > 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -88,7 +88,7 @@ obj-y += crc32.o
> >   obj-$(CONFIG_CRC32C) += crc32c.o
> >   obj-y += ctype.o
> >   obj-y += div64.o
> > -obj-$(CONFIG_OF_LIBFDT) += fdtdec.o
> > +obj-$(CONFIG_OF_LIBFDT) += fdtdec.o fdtdec_common.o
> 
> Shouldn't this be CONFIG_$(SPL_TPL_)OF_LIBFDT?

You are right. I'll use this and do a CI build. If no issue,
I'll post out v2.

Thanks,
Peng

> 
> Regards
> 
> Heinrich
> 
> >   obj-y += hang.o
> >   obj-y += linux_compat.o
> >   obj-y += linux_string.o
> >

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] lib: Makefile: build fdtdec_common.c when OF_LIBFDT selected

2019-05-31 Thread Heinrich Schuchardt 

On 5/31/19 5:11 AM, Peng Fan wrote:

When build SPL_OF_PLATDATA on i.MX6, meet issue the fdtdec_get_int
not defined, however fdtdec.c will use fdtdec_get_int, so let's
compile fdtdec_common.c when OF_LIBFDT selected.

Signed-off-by: Peng Fan 
---
  lib/Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Makefile b/lib/Makefile
index 09c45b8122..66ab6295a5 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -88,7 +88,7 @@ obj-y += crc32.o
  obj-$(CONFIG_CRC32C) += crc32c.o
  obj-y += ctype.o
  obj-y += div64.o
-obj-$(CONFIG_OF_LIBFDT) += fdtdec.o
+obj-$(CONFIG_OF_LIBFDT) += fdtdec.o fdtdec_common.o


Shouldn't this be CONFIG_$(SPL_TPL_)OF_LIBFDT?

Regards

Heinrich


  obj-y += hang.o
  obj-y += linux_compat.o
  obj-y += linux_string.o



___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] lib: Makefile: build fdtdec_common.c when OF_LIBFDT selected

2019-05-30 Thread Peng Fan 
When build SPL_OF_PLATDATA on i.MX6, meet issue the fdtdec_get_int
not defined, however fdtdec.c will use fdtdec_get_int, so let's
compile fdtdec_common.c when OF_LIBFDT selected.

Signed-off-by: Peng Fan 
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Makefile b/lib/Makefile
index 09c45b8122..66ab6295a5 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -88,7 +88,7 @@ obj-y += crc32.o
 obj-$(CONFIG_CRC32C) += crc32c.o
 obj-y += ctype.o
 obj-y += div64.o
-obj-$(CONFIG_OF_LIBFDT) += fdtdec.o
+obj-$(CONFIG_OF_LIBFDT) += fdtdec.o fdtdec_common.o
 obj-y += hang.o
 obj-y += linux_compat.o
 obj-y += linux_string.o
-- 
2.16.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot