Re: [U-Boot] [PATCH] mmc and fat bug fixes

2013-05-17 Thread Andy Fleming
On Thu, May 16, 2013 at 4:26 AM, Ruud Commandeur rcommand...@clb.nl wrote: Assuming this is necessary, I think it then might be time to reorder this: if (!blkcnt) -- possibly at the very start of the function. return 0; if (blkcnt == 1) cmd.cmdidx =

Re: [U-Boot] [PATCH] mmc and fat bug fixes

2013-05-16 Thread Ruud Commandeur
Dear Wolfgang Denk, Thanks for your comments, please see mine below. -Oorspronkelijk bericht- Van: Wolfgang Denk [mailto:w...@denx.de] Verzonden: donderdag 16 mei 2013 7:55 Aan: Ruud Commandeur CC: u-boot@lists.denx.de; Tom Rini; Mats K?rrman Onderwerp: Re: [U-Boot] [PATCH] mmc

Re: [U-Boot] [PATCH] mmc and fat bug fixes

2013-05-16 Thread Ruud Commandeur
-Oorspronkelijk bericht- Van: Andy Fleming [mailto:aflem...@gmail.com] Verzonden: donderdag 16 mei 2013 0:15 Aan: Ruud Commandeur CC: U-Boot list; Tom Rini; Mats K?rrman Onderwerp: Re: [U-Boot] [PATCH] mmc and fat bug fixes On Wed, May 15, 2013 at 9:23 AM, Ruud

[U-Boot] [PATCH] mmc and fat bug fixes

2013-05-15 Thread Ruud Commandeur
This patch fixes a number of mmc and fat-related bugs: Added a check for blkcnt 0 in mmc_write_blocks (drivers/mmc.c) to prevent a hangup for further mmc commands. Solved a checksum issue in fs/fat/fat.c. The mkcksum has const char arguments with a size specifier, like const char name[8].

Re: [U-Boot] [PATCH] mmc and fat bug fixes

2013-05-15 Thread Benoît Thébaudeau
Hi Ruud, On Wednesday, May 15, 2013 4:23:51 PM, Ruud Commandeur wrote: This patch fixes a number of mmc and fat-related bugs: There should be only one logical change per patch. Added a check for blkcnt 0 in mmc_write_blocks (drivers/mmc.c) to prevent a hangup for further mmc commands.

Re: [U-Boot] [PATCH] mmc and fat bug fixes

2013-05-15 Thread Andy Fleming
On Wed, May 15, 2013 at 9:23 AM, Ruud Commandeur rcommand...@clb.nl wrote: This patch fixes a number of mmc and fat-related bugs: Added a check for blkcnt 0 in mmc_write_blocks (drivers/mmc.c) to prevent a hangup for further mmc commands. You need more information than that. Why is some

Re: [U-Boot] [PATCH] mmc and fat bug fixes

2013-05-15 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/15/2013 11:37 AM, Benoît Thébaudeau wrote: Hi Ruud, On Wednesday, May 15, 2013 4:23:51 PM, Ruud Commandeur wrote: This patch fixes a number of mmc and fat-related bugs: [snip] @@ -901,7 +902,8 @@ } curclust = get_fatent_value(mydata,

Re: [U-Boot] [PATCH] mmc and fat bug fixes

2013-05-15 Thread Wolfgang Denk
Dear Ruud Commandeur, In message 15ae5a936f5e3a42a9144e66875a0a89308...@server1-derijp.clb-Benelux.lokaal you wrote: This patch fixes a number of mmc and fat-related bugs: Added a check for blkcnt 0 in mmc_write_blocks (drivers/mmc.c) to preve= nt a hangup for further mmc commands.