Re: [U-Boot] [PATCH] phy: ti: Init node before reading
Hi Michal, On Tue, Apr 9, 2019 at 5:51 AM Michal Simek wrote: > > On 17. 03. 19 0:06, Hannes Schmelzer wrote: > > "U-Boot" schrieb am 16.03.2019 12:43:17: > > > >> Von: Michal Simek > >> An: u-boot@lists.denx.de > >> Kopie: Janine Hagemann , Joe Hershberger > >> , Hannes Schmelzer > >> Datum: 16.03.2019 12:43 > >> Betreff: [U-Boot] [PATCH] phy: ti: Init node before reading > >> Gesendet von: "U-Boot" > >> > >> There is a need to fill node before clk_output_sel is setup. > >> > >> Signed-off-by: Michal Simek > >> Acked-by: Siva Durga Prasad Paladugu > >> --- > >> > >> drivers/net/phy/ti.c | 8 > >> 1 file changed, 4 insertions(+), 4 deletions(-) > > > > Reviewed-by: > > Joe: Do you want to take it via your net tree? Sure, I'll take it through my tree. I have to figure out which patch on my tree is breaking Tom's board, but once I get that figured out, I'll be pulling things in. I see it is already delegated to me in patchwork. Thanks, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] phy: ti: Init node before reading
On 17. 03. 19 0:06, Hannes Schmelzer wrote: > "U-Boot" schrieb am 16.03.2019 12:43:17: > >> Von: Michal Simek >> An: u-boot@lists.denx.de >> Kopie: Janine Hagemann , Joe Hershberger >> , Hannes Schmelzer >> Datum: 16.03.2019 12:43 >> Betreff: [U-Boot] [PATCH] phy: ti: Init node before reading >> Gesendet von: "U-Boot" >> >> There is a need to fill node before clk_output_sel is setup. >> >> Signed-off-by: Michal Simek >> Acked-by: Siva Durga Prasad Paladugu >> --- >> >> drivers/net/phy/ti.c | 8 >> 1 file changed, 4 insertions(+), 4 deletions(-) > > Reviewed-by: Joe: Do you want to take it via your net tree? Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs signature.asc Description: OpenPGP digital signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] phy: ti: Init node before reading
Hi, On 18. 03. 19 9:38, Lukasz Majewski wrote: > Hi Michal, > >> There is a need to fill node before clk_output_sel is setup. > > Could you be more specific about this issue ? > > I assume that the issue is on a system where Xilinx is used. I did my > work/testing on a system where TI's SoC was used instead, so I'm curious > what are the problems on Xilinx. I didn't run this on any board - it is just fixing logic there. Just look at the code that this. ofnode_read_u32_default(node, "ti,clk-output-sel", is using node. But node variable is not initialized at that time. It initialized below this. It means I expect that this read will always setup default value no matter what you have in ti,clk-output-sel property. Thanks, Michal ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] phy: ti: Init node before reading
Hi Michal, > There is a need to fill node before clk_output_sel is setup. Could you be more specific about this issue ? I assume that the issue is on a system where Xilinx is used. I did my work/testing on a system where TI's SoC was used instead, so I'm curious what are the problems on Xilinx. Thanks in advance. > > Signed-off-by: Michal Simek > Acked-by: Siva Durga Prasad Paladugu > --- > > drivers/net/phy/ti.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c > index 6db6edd0d0c8..10989dd40309 100644 > --- a/drivers/net/phy/ti.c > +++ b/drivers/net/phy/ti.c > @@ -216,6 +216,10 @@ static int dp83867_of_init(struct phy_device > *phydev) > /* Optional configuration */ > > + node = phy_get_ofnode(phydev); > + if (!ofnode_valid(node)) > + return -EINVAL; > + > /* >* Keep the default value if ti,clk-output-sel is not set >* or to high > @@ -225,10 +229,6 @@ static int dp83867_of_init(struct phy_device > *phydev) ofnode_read_u32_default(node, "ti,clk-output-sel", > DP83867_CLK_O_SEL_REF_CLK); > > - node = phy_get_ofnode(phydev); > - if (!ofnode_valid(node)) > - return -EINVAL; > - > if (ofnode_read_bool(node, "ti,max-output-impedance")) > dp83867->io_impedance = > DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX; else if (ofnode_read_bool(node, > "ti,min-output-impedance")) Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de pgpYSE2bfVJWm.pgp Description: OpenPGP digital signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] phy: ti: Init node before reading
"U-Boot" schrieb am 16.03.2019 12:43:17: > Von: Michal Simek > An: u-boot@lists.denx.de > Kopie: Janine Hagemann , Joe Hershberger > , Hannes Schmelzer > Datum: 16.03.2019 12:43 > Betreff: [U-Boot] [PATCH] phy: ti: Init node before reading > Gesendet von: "U-Boot" > > There is a need to fill node before clk_output_sel is setup. > > Signed-off-by: Michal Simek > Acked-by: Siva Durga Prasad Paladugu > --- > > drivers/net/phy/ti.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH] phy: ti: Init node before reading
There is a need to fill node before clk_output_sel is setup. Signed-off-by: Michal Simek Acked-by: Siva Durga Prasad Paladugu --- drivers/net/phy/ti.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c index 6db6edd0d0c8..10989dd40309 100644 --- a/drivers/net/phy/ti.c +++ b/drivers/net/phy/ti.c @@ -216,6 +216,10 @@ static int dp83867_of_init(struct phy_device *phydev) /* Optional configuration */ + node = phy_get_ofnode(phydev); + if (!ofnode_valid(node)) + return -EINVAL; + /* * Keep the default value if ti,clk-output-sel is not set * or to high @@ -225,10 +229,6 @@ static int dp83867_of_init(struct phy_device *phydev) ofnode_read_u32_default(node, "ti,clk-output-sel", DP83867_CLK_O_SEL_REF_CLK); - node = phy_get_ofnode(phydev); - if (!ofnode_valid(node)) - return -EINVAL; - if (ofnode_read_bool(node, "ti,max-output-impedance")) dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX; else if (ofnode_read_bool(node, "ti,min-output-impedance")) -- 1.9.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
