Re: [U-Boot] [PATCH] powerpc, muas3001: remove CONFIG_SYS_RAMBOOT

2014-12-05 Thread York Sun
On 11/06/2014 06:20 AM, Heiko Schocher wrote:
 cppcheck reports:
 
 [board/muas3001/muas3001.c:270]: (error) Uninitialized variable: psize
 
 remove the CONFIG_SYS_RAMBOOT define to prevent this error report.
 
 Signed-off-by: Heiko Schocher h...@denx.de
 Reported-by: Wolfgang Denk w...@denx.de
 
 ---
 

Applied to u-boot-mpc85xx, awaiting upstream.

York

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] powerpc, muas3001: remove CONFIG_SYS_RAMBOOT

2014-11-06 Thread Heiko Schocher
cppcheck reports:

[board/muas3001/muas3001.c:270]: (error) Uninitialized variable: psize

remove the CONFIG_SYS_RAMBOOT define to prevent this error report.

Signed-off-by: Heiko Schocher h...@denx.de
Reported-by: Wolfgang Denk w...@denx.de

---

 board/muas3001/muas3001.c  | 4 
 include/configs/muas3001.h | 4 
 2 files changed, 8 deletions(-)

diff --git a/board/muas3001/muas3001.c b/board/muas3001/muas3001.c
index 08eb5e8..812a7f1 100644
--- a/board/muas3001/muas3001.c
+++ b/board/muas3001/muas3001.c
@@ -243,14 +243,11 @@ phys_size_t initdram (int board_type)
volatile immap_t *immap = (immap_t *) CONFIG_SYS_IMMR;
volatile memctl8260_t *memctl = immap-im_memctl;
long psize;
-#ifndef CONFIG_SYS_RAMBOOT
long sizelittle, sizebig;
-#endif
 
memctl-memc_psrt = CONFIG_SYS_PSRT;
memctl-memc_mptpr = CONFIG_SYS_MPTPR;
 
-#ifndef CONFIG_SYS_RAMBOOT
/* 60x SDRAM setup:
 */
sizelittle = try_init (memctl, CONFIG_SYS_PSDMR_LITTLE, 
CONFIG_SYS_OR1_LITTLE,
@@ -263,7 +260,6 @@ phys_size_t initdram (int board_type)
psize = try_init (memctl, CONFIG_SYS_PSDMR_LITTLE, 
CONFIG_SYS_OR1_LITTLE,
  (uchar *) 
CONFIG_SYS_SDRAM_BASE);
}
-#endif /* CONFIG_SYS_RAMBOOT */
 
icache_enable ();
 
diff --git a/include/configs/muas3001.h b/include/configs/muas3001.h
index 7343c94..df2ecc1 100644
--- a/include/configs/muas3001.h
+++ b/include/configs/muas3001.h
@@ -206,10 +206,6 @@
 #define CONFIG_SYS_FLASH_BANKS_LIST { CONFIG_SYS_FLASH_BASE }
 
 #define CONFIG_SYS_MONITOR_BASECONFIG_SYS_TEXT_BASE
-#if (CONFIG_SYS_MONITOR_BASE  CONFIG_SYS_FLASH_BASE)
-#define CONFIG_SYS_RAMBOOT
-#endif
-
 #define CONFIG_SYS_MONITOR_LEN (256  10) /* Reserve 256KB for 
Monitor */
 
 #define CONFIG_ENV_IS_IN_FLASH
-- 
1.8.3.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot