Re: [U-Boot] [PATCH] rockchip: video: fix taking the VOP device out of standby

2017-06-12 Thread Simon Glass
Hi, On 9 June 2017 at 11:02, Anatolij Gustschin wrote: > Hi Simon, > > On Fri, 9 Jun 2017 18:24:37 +0200 > Philipp Tomsich philipp.toms...@theobroma-systems.com wrote: > >> The VOP uses regular registers, so use setbits_le32/clrbits_le32 >> instead of rk_setbits/rk_clrbits. > >

[U-Boot] [PATCH] rockchip: video: fix taking the VOP device out of standby

2017-06-09 Thread Philipp Tomsich
The VOP uses regular registers, so use setbits_le32/clrbits_le32 instead of rk_setbits/rk_clrbits. Signed-off-by: Philipp Tomsich --- drivers/video/rockchip/rk3288_vop.c | 2 +- drivers/video/rockchip/rk_vop.c | 2 +- 2 files changed, 2 insertions(+),

Re: [U-Boot] [PATCH] rockchip: video: fix taking the VOP device out of standby

2017-06-09 Thread Dr. Philipp Tomsich
Anatolij, This is against u-boot-dm/master and a fix-up for the errors that Tom reported in response to Simon’s pull-request (for u-boot-dm). I haven’t bothered to find out what tree the underlying patch came in through… Philipp. > On 09 Jun 2017, at 18:45, Anatolij Gustschin

Re: [U-Boot] [PATCH] rockchip: video: fix taking the VOP device out of standby

2017-06-09 Thread Anatolij Gustschin
Hi Simon, On Fri, 9 Jun 2017 18:24:37 +0200 Philipp Tomsich philipp.toms...@theobroma-systems.com wrote: > The VOP uses regular registers, so use setbits_le32/clrbits_le32 > instead of rk_setbits/rk_clrbits. these could be changed when applying, to match with the code:

Re: [U-Boot] [PATCH] rockchip: video: fix taking the VOP device out of standby

2017-06-09 Thread Anatolij Gustschin
On Fri, 9 Jun 2017 18:48:53 +0200 Dr. Philipp Tomsich philipp.toms...@theobroma-systems.com wrote: > Anatolij, > > This is against u-boot-dm/master and a fix-up for the errors that Tom > reported in response to Simon’s pull-request (for u-boot-dm). > > I haven’t bothered to find out what tree

Re: [U-Boot] [PATCH] rockchip: video: fix taking the VOP device out of standby

2017-06-09 Thread Anatolij Gustschin
Hi Philipp, On Fri, 9 Jun 2017 18:24:37 +0200 Philipp Tomsich philipp.toms...@theobroma-systems.com wrote: ... > --- a/drivers/video/rockchip/rk3288_vop.c > +++ b/drivers/video/rockchip/rk3288_vop.c > @@ -75,7 +75,7 @@ static int rk_vop_remove(struct udevice *dev) > struct rk_vop_priv