Re: [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places

2013-06-17 Thread Stefano Babic
On 14/06/2013 15:18, Jagan Teki wrote: This does not scale. What if a (trivial) patch touches 10 drivers? Yes, you are correct if the changes is common to across the all drivers or If the changes which are more in 10 spi drivers out of 20 or 10 for your example - use spi: and I think it's

[U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places

2013-06-14 Thread Axel Lin
This change slightly improves readability. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/cf_qspi.c | 2 +- drivers/spi/mxc_spi.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/cf_qspi.c b/drivers/spi/cf_qspi.c index a37ac4e..06bcf91 100644

Re: [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places

2013-06-14 Thread Jagan Teki
Hi, IMHO: Can you please use the proper commit header prefix. I am just sharing my thoughts, ignore this if you know it already. I followed below syntax. main_module: sub_module: sub_sub_module: COMMIT_HEADER Ex: for this commit (seems like this commit changes two drivers) spi: cf_qspi |

Re: [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places

2013-06-14 Thread Axel Lin
2013/6/14 Jagan Teki jagannadh.t...@gmail.com: Hi, IMHO: Can you please use the proper commit header prefix. I am just sharing my thoughts, ignore this if you know it already. I followed below syntax. main_module: sub_module: sub_sub_module: COMMIT_HEADER Ex: for this commit (seems

Re: [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places

2013-06-14 Thread Jagan Teki
On Fri, Jun 14, 2013 at 6:39 PM, Axel Lin axel@ingics.com wrote: 2013/6/14 Jagan Teki jagannadh.t...@gmail.com: Hi, IMHO: Can you please use the proper commit header prefix. I am just sharing my thoughts, ignore this if you know it already. I followed below syntax. main_module:

Re: [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places

2013-06-14 Thread Richard Retanubun
On 14/06/13 09:09 AM, Axel Lin wrote: 2013/6/14 Jagan Tekijagannadh.t...@gmail.com: Hi, IMHO: Can you please use the proper commit header prefix. I am just sharing my thoughts, ignore this if you know it already. I followed below syntax. main_module:sub_module:sub_sub_module:COMMIT_HEADER

Re: [U-Boot] [PATCH] spi: Use DIV_ROUND_UP at appropriate places

2013-06-14 Thread Jagan Teki
On Fri, Jun 14, 2013 at 6:54 PM, Richard Retanubun richardretanu...@ruggedcom.com wrote: On 14/06/13 09:09 AM, Axel Lin wrote: 2013/6/14 Jagan Tekijagannadh.t...@gmail.com: Hi, IMHO: Can you please use the proper commit header prefix. I am just sharing my thoughts, ignore this if you