Re: [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL

2019-01-17 Thread Chee, Tien Fong 
On Thu, 2019-01-17 at 07:23 -0500, Tom Rini wrote:
> On Thu, Jan 17, 2019 at 03:01:49PM +0800, tien.fong.c...@intel.com
> wrote:
> 
> > 
> > From: Tien Fong Chee 
> > 
> > CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4
> > from
> > SPL build. Excluding the FS EXT4 from SPL build can help to save
> > 20KiB
> > memory.
> > 
> > Signed-off-by: Tien Fong Chee 
> > ---
> >  fs/fs.c |4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/fs/fs.c b/fs/fs.c
> > index 0b8088b..252e2f5 100644
> > --- a/fs/fs.c
> > +++ b/fs/fs.c
> > @@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
> >     .closedir = fat_closedir,
> >     },
> >  #endif
> > -#ifdef CONFIG_FS_EXT4
> > +/* #ifdef CONFIG_FS_EXT4 */
> > +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
> > +   (defined(CONFIG_SPL_BUILD) &&
> > defined(CONFIG_SPL_EXT_SUPPORT))
> >     {
> >     .fstype = FS_TYPE_EXT,
> >     .name = "ext4",
> This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2
> patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!
Okay.
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL

2019-01-17 Thread Tom Rini 
On Thu, Jan 17, 2019 at 03:01:49PM +0800, tien.fong.c...@intel.com wrote:

> From: Tien Fong Chee 
> 
> CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from
> SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB
> memory.
> 
> Signed-off-by: Tien Fong Chee 
> ---
>  fs/fs.c |4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/fs.c b/fs/fs.c
> index 0b8088b..252e2f5 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
>   .closedir = fat_closedir,
>   },
>  #endif
> -#ifdef CONFIG_FS_EXT4
> +/* #ifdef CONFIG_FS_EXT4 */
> +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
> + (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_EXT_SUPPORT))
>   {
>   .fstype = FS_TYPE_EXT,
>   .name = "ext4",

This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2
patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL

2019-01-16 Thread tien . fong . chee 
From: Tien Fong Chee 

CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from
SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB
memory.

Signed-off-by: Tien Fong Chee 
---
 fs/fs.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/fs.c b/fs/fs.c
index 0b8088b..252e2f5 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
.closedir = fat_closedir,
},
 #endif
-#ifdef CONFIG_FS_EXT4
+/* #ifdef CONFIG_FS_EXT4 */
+#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
+   (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_EXT_SUPPORT))
{
.fstype = FS_TYPE_EXT,
.name = "ext4",
-- 
1.7.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot