Re: [U-Boot] [PATCH] usb: kbd: Fix dangling pointers on probe fail

2017-10-05 Thread Rob Clark
On Thu, Oct 5, 2017 at 7:48 PM, Bin Meng wrote: > Hi Rob, > > On Wed, Oct 4, 2017 at 1:31 AM, Rob Clark wrote: >> If probe fails, we should unregister the stdio device, else we leave >> dangling pointers to the parent 'struct usb_device'. >> >>

Re: [U-Boot] [PATCH] usb: kbd: Fix dangling pointers on probe fail

2017-10-05 Thread Bin Meng
Hi Rob, On Wed, Oct 4, 2017 at 1:31 AM, Rob Clark wrote: > If probe fails, we should unregister the stdio device, else we leave > dangling pointers to the parent 'struct usb_device'. > > Signed-off-by: Rob Clark > --- > I finally got around to debugging

Re: [U-Boot] [PATCH] usb: kbd: Fix dangling pointers on probe fail

2017-10-05 Thread Peter Robinson
On Tue, Oct 3, 2017 at 6:31 PM, Rob Clark wrote: > If probe fails, we should unregister the stdio device, else we leave > dangling pointers to the parent 'struct usb_device'. > > Signed-off-by: Rob Clark Tested-by: Peter Robinson

[U-Boot] [PATCH] usb: kbd: Fix dangling pointers on probe fail

2017-10-03 Thread Rob Clark
If probe fails, we should unregister the stdio device, else we leave dangling pointers to the parent 'struct usb_device'. Signed-off-by: Rob Clark --- I finally got around to debugging why things explode so badly without fixing usb_kbd vs. iomux[1] (which this patch applies