Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2010-01-17 Thread Wolfgang Denk
Dear Sanjeev, in message b85a65d85d7eb246be421b3fb0fbb59301e1eb4...@dbde02.ent.ti.com you wrote: Also, I believe faster execution time is always better; not just in critical sections of code. I possibly used global quite loosely; while responding earlier. The variable cpu_revision (being

Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2010-01-12 Thread Tom
Premi, Sanjeev wrote: -Original Message- From: Paulraj, Sandeep Sent: Thursday, January 07, 2010 9:02 PM To: Premi, Sanjeev; u-boot@lists.denx.de Subject: RE: [PATCH 0/2] omap3: Optimize detection of cpu revision -Original Message- From: Premi, Sanjeev Sent: Tuesday,

Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2010-01-11 Thread Premi, Sanjeev
-Original Message- From: Paulraj, Sandeep Sent: Thursday, January 07, 2010 9:02 PM To: Premi, Sanjeev; u-boot@lists.denx.de Subject: RE: [PATCH 0/2] omap3: Optimize detection of cpu revision -Original Message- From: Premi, Sanjeev Sent: Tuesday, December 15, 2009

Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2010-01-08 Thread Premi, Sanjeev
-Original Message- From: Paulraj, Sandeep Sent: Thursday, January 07, 2010 9:02 PM To: Premi, Sanjeev; u-boot@lists.denx.de Subject: RE: [PATCH 0/2] omap3: Optimize detection of cpu revision -Original Message- From: Premi, Sanjeev Sent: Tuesday, December 15,

Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2010-01-07 Thread Premi, Sanjeev
-Original Message- From: Premi, Sanjeev Sent: Tuesday, December 15, 2009 6:48 PM To: u-boot@lists.denx.de Cc: Premi, Sanjeev Subject: [PATCH 0/2] omap3: Optimize detection of cpu revision Each call to get_cpu_rev() leads to repetitive execution of code to detect the cpu

Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2010-01-07 Thread Paulraj, Sandeep
-Original Message- From: Premi, Sanjeev Sent: Tuesday, December 15, 2009 6:48 PM To: u-boot@lists.denx.de Cc: Premi, Sanjeev Subject: [PATCH 0/2] omap3: Optimize detection of cpu revision Each call to get_cpu_rev() leads to repetitive execution of code to detect the

Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2009-12-16 Thread Wolfgang Denk
Dear Premi, Sanjeev, In message b85a65d85d7eb246be421b3fb0fbb59301e157a...@dbde02.ent.ti.com you wrote: Also, I don't believe there is any complexity added as the contents of register are being read and saved in a global variable for use later. Global variables are a bad thing if there is

[U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2009-12-15 Thread Sanjeev Premi
Each call to get_cpu_rev() leads to repetitive execution of code to detect the cpu revision. This patchset ensures that mechanism to detect revision is not executed each time; instead a stored value is returned. Since, revision info is needed in s_init(), the function to identify cpu revision

Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2009-12-15 Thread Tom
Sanjeev Premi wrote: Each call to get_cpu_rev() leads to repetitive execution of code to detect the cpu revision. This patchset ensures that mechanism to detect revision is not executed each time; instead a stored value is returned. Since, revision info is needed in s_init(), the

Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision

2009-12-15 Thread Premi, Sanjeev
-Original Message- From: Tom [mailto:tom@windriver.com] Sent: Tuesday, December 15, 2009 10:44 PM To: Premi, Sanjeev Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision Sanjeev Premi wrote: Each call to get_cpu_rev() leads