Re: [U-Boot] [PATCH 0/4] common: move startup function prototypes in init.h

2018-03-12 Thread Patrick DELAUNAY 
Hi Tom,

> From: Tom Rini [mailto:tr...@konsulko.com]
> 
> > It is a step for common.h cleanup and I don't add documentation for
> > the moved functions.
> 
> Can you add a 5/4 that merges init_helpers.h into this new init.h file?
> There's just one prototype.  Thanks!

Ok, I will this in a v2 of the the patchset.

> --
> Tom

Patrick

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 0/4] common: move startup function prototypes in init.h

2018-03-12 Thread Tom Rini 
On Mon, Mar 12, 2018 at 09:47:15AM +0100, Patrick Delaunay wrote:

> 
> I push this serie after Masahiro Yamada's comment
> on patch "common: add a prototype for mach_cpu_init()"
> 
> The serie depends on v3 of this patch for the added
> file init.h
> 
> I just moved the function used in:
>  common/board_f.c
>  common/init/board_init.c
>  common/board_r.c
>  common/board_info.c
> and solve the checkpatch issue.
> 
> It is a step for common.h cleanup and I don't add
> documentation for the moved functions.
> 
> I don't know if other functions need to be moved:
>   $(BOARD)/$(BOARD).c ?
>   $(CPU)/start.S ?
> 
> or if the order of the new file init.h is correct.

Can you add a 5/4 that merges init_helpers.h into this new init.h file?
There's just one prototype.  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 0/4] common: move startup function prototypes in init.h

2018-03-12 Thread Patrick Delaunay 

I push this serie after Masahiro Yamada's comment
on patch "common: add a prototype for mach_cpu_init()"

The serie depends on v3 of this patch for the added
file init.h

I just moved the function used in:
 common/board_f.c
 common/init/board_init.c
 common/board_r.c
 common/board_info.c
and solve the checkpatch issue.

It is a step for common.h cleanup and I don't add
documentation for the moved functions.

I don't know if other functions need to be moved:
  $(BOARD)/$(BOARD).c ?
  $(CPU)/start.S ?

or if the order of the new file init.h is correct.



Patrick Delaunay (4):
  common: move board_f.c prototypes in init.h
  common: move board_init.c prototypes in init.h
  common: move board_r.c prototypes in init.h
  common: move board_info.c prototypes in init.h

 include/common.h | 128 +++
 include/init.h   | 122 
 2 files changed, 128 insertions(+), 122 deletions(-)

-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot