Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-08 Thread Scott Wood
Wolfgang Denk wrote: >> Would this still be a big problem if the auto-generated defines were put >> in their own namespace (such as the CONFIG_MK_* that you suggested)? > > Probably not a big problem, and maybe not even a practical problem. > But it is still ugly, and nothing I really like. Well,

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-08 Thread Wolfgang Denk
Dear Scott Wood, In message <20090908202143.ga26...@b07421-ec1.am.freescale.net> you wrote: > On Tue, Sep 08, 2009 at 07:46:29PM +0200, Wolfgang Denk wrote: > > > NAND and 36BIT are orthogonal options -- what is wrong with the previous > > > suggestion of splitting them in mkconfig? > > > > I don

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-08 Thread Scott Wood
On Tue, Sep 08, 2009 at 07:46:29PM +0200, Wolfgang Denk wrote: > > NAND and 36BIT are orthogonal options -- what is wrong with the previous > > suggestion of splitting them in mkconfig? > > I don't like this idea as it will pollute the namespace by a number of > uncontrolled auto-generated #define

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-08 Thread Wolfgang Denk
Dear Scott Wood, In message <20090908153825.ga18...@b07421-ec1.am.freescale.net> you wrote: > > > > #ifdef MPC8536DS_36BIT > > > blablabla > > > #endif > > > > That would be CONFIG_MPC8536DS_NAND etc., but except of that that's > > whaty I mean. > > NAND and 36BIT are orthogonal options -- what

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-08 Thread Scott Wood
On Mon, Sep 07, 2009 at 02:38:22PM +0200, Wolfgang Denk wrote: > > then in the include/configs/*.h: > > #ifdef MPC8536DS_NAND > > blablabla > > #endif > > > > #ifdef MPC8536DS_NAND_36BIT > > blablabla > > #endif > > > > #ifdef MPC8536DS_36BIT > > blablabla > > #endif > > That would be CONFIG_MPC85

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-07 Thread Wolfgang Denk
Dear "Hu Mingkai-B21284", In message <73839b4a0818e747864426270ac332c30447e...@zmy16exm20.fsl.freescale.net> you wrote: > ... [Full quote deleted] ... > > You already know the board name, because the board config=20 > > file is clearly related ot one (or eventually more) boards.=20 > > The rest

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-07 Thread Hu Mingkai-B21284
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, September 07, 2009 6:59 PM > To: Hu Mingkai-B21284 > Cc: Kumar Gala; Wood Scott-B07421; U-Boot-Users ML; Mike Frysinger > Subject: Re: [PATCH 01/10] mkconfig: parse top level makefile > target to multiple

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-07 Thread Wolfgang Denk
Dear "Hu Mingkai-B21284", In message <73839b4a0818e747864426270ac332c30447e...@zmy16exm20.fsl.freescale.net> you wrote: > > > > > It should be enough to pass the make target name to the mkconfig > > > > script resp. the board config file, i. e. in this case either > > > > "CONFIG_MPC8536DS_NA

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-07 Thread Hu Mingkai-B21284
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, September 07, 2009 6:18 PM > To: Hu Mingkai-B21284 > Cc: Kumar Gala; Wood Scott-B07421; U-Boot-Users ML; Mike Frysinger > Subject: Re: [PATCH 01/10] mkconfig: parse top level makefile > target to multiple

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-07 Thread Wolfgang Denk
Dear "Hu Mingkai-B21284", In message <73839b4a0818e747864426270ac332c30447e...@zmy16exm20.fsl.freescale.net> you wrote: > > > It should be enough to pass the make target name to the > > mkconfig script resp. the board config file, i. e. in this > > case either "CONFIG_MPC8536DS_NAND" or > > "

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-07 Thread Hu Mingkai-B21284
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Saturday, September 05, 2009 3:43 AM > To: Hu Mingkai-B21284 > Cc: Kumar Gala; Wood Scott-B07421; U-Boot-Users ML; Mike Frysinger > Subject: Re: [PATCH 01/10] mkconfig: parse top level makefile > target to multipl

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-09-04 Thread Wolfgang Denk
Dear "Hu Mingkai-B21284", sorry for the late reply [I have to admit that I kind of loist track where we are with this discussion - too many diverging statements found]. In message <73839b4a0818e747864426270ac332c3043f5...@zmy16exm20.fsl.freescale.net> you wrote: > > How do you think of this me

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-08-21 Thread Hu Mingkai-B21284
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Tuesday, August 18, 2009 11:07 PM > To: Wolfgang Denk > Cc: Wood Scott-B07421; U-Boot-Users ML; Hu Mingkai-B21284; > Mike Frysinger > Subject: Re: [PATCH 01/10] mkconfig: parse top level makefile > target

Re: [U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-08-18 Thread Kumar Gala
On Aug 18, 2009, at 2:37 AM, Mingkai Hu wrote: > To simplify the top level makefile it useful to be able to paree > the top level makefile target to multiple individual target, then > put them to the config.h and config.mk, leave the board config file > and board makefile to handle the different

[U-Boot] [PATCH 01/10] mkconfig: parse top level makefile target to multiple config targets

2009-08-18 Thread Mingkai Hu
To simplify the top level makefile it useful to be able to paree the top level makefile target to multiple individual target, then put them to the config.h and config.mk, leave the board config file and board makefile to handle the different targets. --- mkconfig | 11 +++ 1 files change