Re: [U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-02-07 Thread Joe Hershberger
Hi Mike, On Fri, Feb 3, 2012 at 5:44 AM, Mike Frysinger vap...@gentoo.org wrote: in general, i like this.  my only concern would be the drivers that might break due to incorrect cache management (which the volatile markers happen to work around for them). having the API accept a volatile but

Re: [U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-02-03 Thread Mike Frysinger
On Tuesday 24 January 2012 01:27:53 Joe Hershberger wrote: On Tue, Jan 24, 2012 at 12:09 AM, Simon Glass wrote: On Fri, Jan 20, 2012 at 12:15 PM, Joe Hershberger wrote: On Fri, Jan 20, 2012 at 10:22 AM, Simon Glass wrote: On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger wrote: @@ -1454,9

Re: [U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-02-03 Thread Mike Frysinger
in general, i like this. my only concern would be the drivers that might break due to incorrect cache management (which the volatile markers happen to work around for them). having the API accept a volatile but then casting it away puts us in a worse place i think. on one hand, our API is

Re: [U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-01-23 Thread Simon Glass
Hi Joe, On Fri, Jan 20, 2012 at 12:15 PM, Joe Hershberger joe.hershber...@gmail.com wrote: Hi Simon, On Fri, Jan 20, 2012 at 10:22 AM, Simon Glass s...@chromium.org wrote: Hi Joe, On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger joe.hershber...@ni.com wrote: The mv_eth driver should not

Re: [U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-01-23 Thread Joe Hershberger
Hi Simon, On Tue, Jan 24, 2012 at 12:09 AM, Simon Glass s...@chromium.org wrote: Hi Joe, On Fri, Jan 20, 2012 at 12:15 PM, Joe Hershberger joe.hershber...@gmail.com wrote: Hi Simon, On Fri, Jan 20, 2012 at 10:22 AM, Simon Glass s...@chromium.org wrote: Hi Joe, On Thu, Jan 19, 2012 at

[U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-01-20 Thread Joe Hershberger
The mv_eth driver should not redefine the net function definition Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com Cc: Wolfgang Denk w...@denx.de --- board/Marvell/db64360/mv_eth.c |2 -- board/Marvell/db64460/mv_eth.c |2 --

Re: [U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-01-20 Thread Simon Glass
Hi Joe, On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger joe.hershber...@ni.com wrote: The mv_eth driver should not redefine the net function definition Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com Cc: Wolfgang Denk w...@denx.de ---  

Re: [U-Boot] [PATCH 01/28] net: Remove volatile from all of net except the eth driver interface

2012-01-20 Thread Joe Hershberger
Hi Simon, On Fri, Jan 20, 2012 at 10:22 AM, Simon Glass s...@chromium.org wrote: Hi Joe, On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger joe.hershber...@ni.com wrote: The mv_eth driver should not redefine the net function definition Signed-off-by: Joe Hershberger joe.hershber...@ni.com