Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

Joe, > On 14 Jun 2018, at 20:26, Joe Hershberger wrote: > > On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich > wrote: >> >>> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: >>> >>> On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann >>> wrote: We have to use

Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich wrote: > >> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: >> >> On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann >> wrote: >>> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >>> RK3328_RXCLK_DLY_ENA_GMAC_MASK in

Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: > > On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann wrote: >> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() >> to enable the RX delay. >> The MASK was used in a

Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann wrote: > We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of > RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() > to enable the RX delay. > The MASK was used in a wrong way. > > Signed-off-by: Janine Hagemann Acked-by: Joe

[U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() to enable the RX delay. The MASK was used in a wrong way. Signed-off-by: Janine Hagemann --- drivers/net/gmac_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)