Re: [U-Boot] [PATCH 05/12] sunxi: Move setting of CPU system control register SMP bit to save_boot_params

2015-01-20 Thread Ian Campbell
On Mon, 2015-01-19 at 20:04 +0100, Hans de Goede wrote: Hi, On 17-01-15 23:51, Ian Campbell wrote: On Thu, 2015-01-15 at 15:52 +0100, Hans de Goede wrote: According to the Cortex-A7 MPCore Technical Reference Manual: You must ensure this bit is set to 1 before the caches and MMU are

Re: [U-Boot] [PATCH 05/12] sunxi: Move setting of CPU system control register SMP bit to save_boot_params

2015-01-20 Thread Albert ARIBAUD
Hello Hans, On Mon, 19 Jan 2015 20:04:58 +0100, Hans de Goede hdego...@redhat.com wrote: Hi, On 17-01-15 23:51, Ian Campbell wrote: On Thu, 2015-01-15 at 15:52 +0100, Hans de Goede wrote: According to the Cortex-A7 MPCore Technical Reference Manual: You must ensure this bit is set to

Re: [U-Boot] [PATCH 05/12] sunxi: Move setting of CPU system control register SMP bit to save_boot_params

2015-01-20 Thread Hans de Goede
Hi, On 20-01-15 11:22, Albert ARIBAUD wrote: Hello Hans, On Mon, 19 Jan 2015 20:04:58 +0100, Hans de Goede hdego...@redhat.com wrote: Hi, On 17-01-15 23:51, Ian Campbell wrote: On Thu, 2015-01-15 at 15:52 +0100, Hans de Goede wrote: According to the Cortex-A7 MPCore Technical Reference

Re: [U-Boot] [PATCH 05/12] sunxi: Move setting of CPU system control register SMP bit to save_boot_params

2015-01-20 Thread Albert ARIBAUD
Hello Hans, On Tue, 20 Jan 2015 15:32:34 +0100, Hans de Goede hdego...@redhat.com wrote: Hi, On 20-01-15 11:22, Albert ARIBAUD wrote: Hello Hans, I'm leaning toward grouping all CP15 inits (including cache(s) and TLB disabling and maybe VBAR setting) in a single CP15 call to a

Re: [U-Boot] [PATCH 05/12] sunxi: Move setting of CPU system control register SMP bit to save_boot_params

2015-01-19 Thread Albert ARIBAUD
Hello Hans, On Mon, 19 Jan 2015 20:04:58 +0100, Hans de Goede hdego...@redhat.com wrote: Hi, On 17-01-15 23:51, Ian Campbell wrote: On Thu, 2015-01-15 at 15:52 +0100, Hans de Goede wrote: According to the Cortex-A7 MPCore Technical Reference Manual: You must ensure this bit is set to

Re: [U-Boot] [PATCH 05/12] sunxi: Move setting of CPU system control register SMP bit to save_boot_params

2015-01-19 Thread Hans de Goede
Hi, On 17-01-15 23:51, Ian Campbell wrote: On Thu, 2015-01-15 at 15:52 +0100, Hans de Goede wrote: According to the Cortex-A7 MPCore Technical Reference Manual: You must ensure this bit is set to 1 before the caches and MMU are enabled, or any cache and TLB maintenance operations are

Re: [U-Boot] [PATCH 05/12] sunxi: Move setting of CPU system control register SMP bit to save_boot_params

2015-01-17 Thread Ian Campbell
On Thu, 2015-01-15 at 15:52 +0100, Hans de Goede wrote: According to the Cortex-A7 MPCore Technical Reference Manual: You must ensure this bit is set to 1 before the caches and MMU are enabled, or any cache and TLB maintenance operations are performed. Given that this is a feature of the

[U-Boot] [PATCH 05/12] sunxi: Move setting of CPU system control register SMP bit to save_boot_params

2015-01-15 Thread Hans de Goede
According to the Cortex-A7 MPCore Technical Reference Manual: You must ensure this bit is set to 1 before the caches and MMU are enabled, or any cache and TLB maintenance operations are performed. Since arch/arm/cpu/armv7/start.S: cpu_init_cp15 does several cache operations, we should thus