Re: [U-Boot] [PATCH 07/14] sunxi: axp221: Disable dcdc4 on sun8i (A23)

[Ian Campbell]

On Tue, 2014-12-16 at 21:31 +0100, Hans de Goede wrote:
 dcdc4 is not used on sun8i, disable it.
 
 While at it also add comments to the other fixed voltages to document what
 they are used for.
 
 Signed-off-by: Hans de Goede hdego...@redhat.com

Acked-by: Ian Campbell i...@hellion.org.uk

(although I'm wondering if it might have been better to make this
Kconfigurable...)


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 07/14] sunxi: axp221: Disable dcdc4 on sun8i (A23)

[Hans de Goede]

dcdc4 is not used on sun8i, disable it.

While at it also add comments to the other fixed voltages to document what
they are used for.

Signed-off-by: Hans de Goede hdego...@redhat.com
---
 board/sunxi/board.c | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/board/sunxi/board.c b/board/sunxi/board.c
index 5bf19b7..7d6d075 100644
--- a/board/sunxi/board.c
+++ b/board/sunxi/board.c
@@ -176,10 +176,14 @@ void sunxi_board_init(void)
 #ifdef CONFIG_AXP221_POWER
power_failed = axp221_init();
power_failed |= axp221_set_dcdc1(CONFIG_AXP221_DCDC1_VOLT);
-   power_failed |= axp221_set_dcdc2(1200);
-   power_failed |= axp221_set_dcdc3(1200);
-   power_failed |= axp221_set_dcdc4(1200);
-   power_failed |= axp221_set_dcdc5(1500);
+   power_failed |= axp221_set_dcdc2(1200); /* A31:VDD-GPU, A23:VDD-SYS */
+   power_failed |= axp221_set_dcdc3(1200); /* VDD-CPU */
+#ifdef CONFIG_MACH_SUN6I
+   power_failed |= axp221_set_dcdc4(1200); /* A31:VDD-SYS */
+#else
+   power_failed |= axp221_set_dcdc4(0);/* A23:unused */
+#endif
+   power_failed |= axp221_set_dcdc5(1500); /* VCC-DRAM */
power_failed |= axp221_set_dldo1(CONFIG_AXP221_DLDO1_VOLT);
power_failed |= axp221_set_dldo4(CONFIG_AXP221_DLDO4_VOLT);
power_failed |= axp221_set_aldo1(CONFIG_AXP221_ALDO1_VOLT);
-- 
2.1.0

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot