Re: [U-Boot] [PATCH 1/1] imx: imx6ull: correct get_cpu_speed_grade_hz on 696MHz SoCs

[Stefano Babic]

On 02/08/2017 15:09, Sébastien Szymanski wrote:
> Hi,
> 
> On 08/02/2017 12:11 PM, Stefano Babic wrote:
>> On 02/08/2017 12:15, Sébastien Szymanski wrote:
>>> Return the correct value when the speed grade is 696MHz.
>>> This makes U-Boot to print the correct value at boot:
>>>
>>> U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 12:02:26 +0200)
>>>
>>> CPU:   Freescale i.MX6ULL rev1.0 696 MHz (running at 396 MHz)
>>>
>>> instead of
>>>
>>> U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 11:47:51 +0200)
>>>
>>> CPU:   Freescale i.MX6ULL rev1.0 69 MHz (running at 396 MHz)
>>> Signed-off-by: Sébastien Szymanski 
>>> ---
>>>  arch/arm/mach-imx/mx6/soc.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c
>>> index af31673..7607456 100644
>>> --- a/arch/arm/mach-imx/mx6/soc.c
>>> +++ b/arch/arm/mach-imx/mx6/soc.c
>>> @@ -130,7 +130,7 @@ u32 get_cpu_speed_grade_hz(void)
>>> if (val == OCOTP_CFG3_SPEED_528MHZ)
>>> return 52800;
>>> else if (val == OCOTP_CFG3_SPEED_696MHZ)
>>> -   return 6960;
>>> +   return 69600;
>>> else
>>> return 0;
>>> }
>>>
>>
>> Reviewed-by: Stefano Babic 
>>
> 
> Thanks. However, I've just noticed this is only true for i.MX6UL.
> i.MX6ULL has different speed grading.>
> Should I resend my patch and fix the commit log?

Yes, thanks for noting thius. I have not yet merged the patch and I
appreciate if this is fixed, too. Please send a V2.

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] imx: imx6ull: correct get_cpu_speed_grade_hz on 696MHz SoCs

[Sébastien Szymanski]

Hi,

On 08/02/2017 12:11 PM, Stefano Babic wrote:
> On 02/08/2017 12:15, Sébastien Szymanski wrote:
>> Return the correct value when the speed grade is 696MHz.
>> This makes U-Boot to print the correct value at boot:
>>
>> U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 12:02:26 +0200)
>>
>> CPU:   Freescale i.MX6ULL rev1.0 696 MHz (running at 396 MHz)
>>
>> instead of
>>
>> U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 11:47:51 +0200)
>>
>> CPU:   Freescale i.MX6ULL rev1.0 69 MHz (running at 396 MHz)
>> Signed-off-by: Sébastien Szymanski 
>> ---
>>  arch/arm/mach-imx/mx6/soc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c
>> index af31673..7607456 100644
>> --- a/arch/arm/mach-imx/mx6/soc.c
>> +++ b/arch/arm/mach-imx/mx6/soc.c
>> @@ -130,7 +130,7 @@ u32 get_cpu_speed_grade_hz(void)
>>  if (val == OCOTP_CFG3_SPEED_528MHZ)
>>  return 52800;
>>  else if (val == OCOTP_CFG3_SPEED_696MHZ)
>> -return 6960;
>> +return 69600;
>>  else
>>  return 0;
>>  }
>>
> 
> Reviewed-by: Stefano Babic 
> 

Thanks. However, I've just noticed this is only true for i.MX6UL.
i.MX6ULL has different speed grading.

Should I resend my patch and fix the commit log?

Best regards,

> Best regards,
> Stefano Babic
> 
> 


-- 
Sébastien Szymanski
Software engineer, Armadeus Systems
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] imx: imx6ull: correct get_cpu_speed_grade_hz on 696MHz SoCs

[Stefano Babic]

On 02/08/2017 12:15, Sébastien Szymanski wrote:
> Return the correct value when the speed grade is 696MHz.
> This makes U-Boot to print the correct value at boot:
> 
> U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 12:02:26 +0200)
> 
> CPU:   Freescale i.MX6ULL rev1.0 696 MHz (running at 396 MHz)
> 
> instead of
> 
> U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 11:47:51 +0200)
> 
> CPU:   Freescale i.MX6ULL rev1.0 69 MHz (running at 396 MHz)
> Signed-off-by: Sébastien Szymanski 
> ---
>  arch/arm/mach-imx/mx6/soc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c
> index af31673..7607456 100644
> --- a/arch/arm/mach-imx/mx6/soc.c
> +++ b/arch/arm/mach-imx/mx6/soc.c
> @@ -130,7 +130,7 @@ u32 get_cpu_speed_grade_hz(void)
>   if (val == OCOTP_CFG3_SPEED_528MHZ)
>   return 52800;
>   else if (val == OCOTP_CFG3_SPEED_696MHZ)
> - return 6960;
> + return 69600;
>   else
>   return 0;
>   }
> 

Reviewed-by: Stefano Babic 

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/1] imx: imx6ull: correct get_cpu_speed_grade_hz on 696MHz SoCs

[Sébastien Szymanski]

Return the correct value when the speed grade is 696MHz.
This makes U-Boot to print the correct value at boot:

U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 12:02:26 +0200)

CPU:   Freescale i.MX6ULL rev1.0 696 MHz (running at 396 MHz)

instead of

U-Boot 2017.09-rc1-dirty (Aug 02 2017 - 11:47:51 +0200)

CPU:   Freescale i.MX6ULL rev1.0 69 MHz (running at 396 MHz)
Signed-off-by: Sébastien Szymanski 
---
 arch/arm/mach-imx/mx6/soc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-imx/mx6/soc.c
index af31673..7607456 100644
--- a/arch/arm/mach-imx/mx6/soc.c
+++ b/arch/arm/mach-imx/mx6/soc.c
@@ -130,7 +130,7 @@ u32 get_cpu_speed_grade_hz(void)
if (val == OCOTP_CFG3_SPEED_528MHZ)
return 52800;
else if (val == OCOTP_CFG3_SPEED_696MHZ)
-   return 6960;
+   return 69600;
else
return 0;
}
-- 
2.7.3

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot