Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-09 Thread Remy Bohmer
Hi Marek, it's hard to evaluate each piece by itself when it's just one patch smooshing it all together Well how would you rework crap code piece by piece? - fix style - abstract out stuff Not like there was so much abstraction it couldn't be squashed into this one. - add new

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-09 Thread Marek Vasut
On Sunday, October 09, 2011 11:01:36 AM Remy Bohmer wrote: Hi Marek, it's hard to evaluate each piece by itself when it's just one patch smooshing it all together Well how would you rework crap code piece by piece? - fix style - abstract out stuff Not like there was

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-09 Thread Wolfgang Denk
Dear Marek Vasut, In message 1317990657-17214-2-git-send-email-marek.va...@gmail.com you wrote: Also, fix usb drivers which use extern new. Signed-off-by: Marek Vasut marek.va...@gmail.com Cc: Ajay Kumar Gupta ajay.gu...@ti.com Cc: Bryan Wu bryan...@analog.com Cc: Cliff Cai

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-09 Thread Marek Vasut
On Sunday, October 09, 2011 08:54:07 PM Wolfgang Denk wrote: Dear Marek Vasut, In message 1317990657-17214-2-git-send-email-marek.va...@gmail.com you wrote: Also, fix usb drivers which use extern new. Signed-off-by: Marek Vasut marek.va...@gmail.com Cc: Ajay Kumar Gupta

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-09 Thread Wolfgang Denk
Dear Marek Vasut, In message 201110092112.18014.marek.va...@gmail.com you wrote: +#undef USB_KBD_DEBUG Please do not undef what is not defined [or what a user might want to define on the command line]. Command line ? This is a placeholder in case the user wants to debug this

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-08 Thread Mike Frysinger
On Friday 07 October 2011 08:30:55 Marek Vasut wrote: +#define LEFT_CNTR (1 0) +#define LEFT_SHIFT (1 1) +#define LEFT_ALT(1 2) +#define LEFT_GUI(1 3) +#define RIGHT_CNTR (1 4) +#define RIGHT_SHIFT (1 5) +#define

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-08 Thread Mike Frysinger
On Friday 07 October 2011 16:10:11 Marek Vasut wrote: On Friday, October 07, 2011 07:38:19 PM Mike Frysinger wrote: On Friday 07 October 2011 08:30:55 Marek Vasut wrote: Also, fix usb drivers which use extern new. this summary/changelog is lacking in information as to what you actually

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-08 Thread Marek Vasut
On Saturday, October 08, 2011 09:05:59 PM Mike Frysinger wrote: On Friday 07 October 2011 08:30:55 Marek Vasut wrote: +#defineLEFT_CNTR (1 0) +#defineLEFT_SHIFT (1 1) +#defineLEFT_ALT(1 2) +#defineLEFT_GUI(1 3) +#defineRIGHT_CNTR

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-08 Thread Marek Vasut
On Saturday, October 08, 2011 09:06:30 PM Mike Frysinger wrote: On Friday 07 October 2011 16:10:11 Marek Vasut wrote: On Friday, October 07, 2011 07:38:19 PM Mike Frysinger wrote: On Friday 07 October 2011 08:30:55 Marek Vasut wrote: Also, fix usb drivers which use extern new.

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-08 Thread Mike Frysinger
On Saturday 08 October 2011 15:21:02 Marek Vasut wrote: On Saturday, October 08, 2011 09:05:59 PM Mike Frysinger wrote: On Friday 07 October 2011 08:30:55 Marek Vasut wrote: +#define LEFT_CNTR (1 0) +#define LEFT_SHIFT (1 1) +#define LEFT_ALT(1 2) +#define

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-08 Thread Mike Frysinger
On Saturday 08 October 2011 15:21:17 Marek Vasut wrote: On Saturday, October 08, 2011 09:06:30 PM Mike Frysinger wrote: On Friday 07 October 2011 16:10:11 Marek Vasut wrote: On Friday, October 07, 2011 07:38:19 PM Mike Frysinger wrote: On Friday 07 October 2011 08:30:55 Marek Vasut

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-08 Thread Marek Vasut
On Saturday, October 08, 2011 11:18:28 PM Mike Frysinger wrote: On Saturday 08 October 2011 15:21:17 Marek Vasut wrote: On Saturday, October 08, 2011 09:06:30 PM Mike Frysinger wrote: On Friday 07 October 2011 16:10:11 Marek Vasut wrote: On Friday, October 07, 2011 07:38:19 PM Mike

[U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-07 Thread Marek Vasut
Also, fix usb drivers which use extern new. Signed-off-by: Marek Vasut marek.va...@gmail.com Cc: Ajay Kumar Gupta ajay.gu...@ti.com Cc: Bryan Wu bryan...@analog.com Cc: Cliff Cai cliff@analog.com Cc: Mike Frysinger vap...@gentoo.org Cc: Remy Bohmer li...@bohmer.net Cc: Wolfgang Denk

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-07 Thread Mike Frysinger
On Friday 07 October 2011 08:30:55 Marek Vasut wrote: Also, fix usb drivers which use extern new. this summary/changelog is lacking in information as to what you actually did and why ... -mike signature.asc Description: This is a digitally signed message part.

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-07 Thread Marek Vasut
On Friday, October 07, 2011 07:38:19 PM Mike Frysinger wrote: On Friday 07 October 2011 08:30:55 Marek Vasut wrote: Also, fix usb drivers which use extern new. this summary/changelog is lacking in information as to what you actually did and why ... -mike Hi Mike, generally shuffling with