Re: [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value

2016-04-09 Thread Simon Glass
Hi Peng, On 4 April 2016 at 23:04, Peng Fan wrote: > Hi Stefano, > > On Sun, Apr 03, 2016 at 08:09:35PM +0200, Stefano Babic wrote: >>Hi Peng, >> >>On 17/03/2016 02:44, Peng Fan wrote: >>> On Wed, Mar 16, 2016 at 09:48:24AM -0300, Fabio Estevam wrote: Hi Peng,

Re: [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value

2016-04-04 Thread Peng Fan
Hi Stefano, On Sun, Apr 03, 2016 at 08:09:35PM +0200, Stefano Babic wrote: >Hi Peng, > >On 17/03/2016 02:44, Peng Fan wrote: >> On Wed, Mar 16, 2016 at 09:48:24AM -0300, Fabio Estevam wrote: >>> Hi Peng, >>> >>> On Tue, Mar 15, 2016 at 10:27 PM, Peng Fan wrote: >>> If

Re: [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value

2016-04-03 Thread Stefano Babic
Hi Peng, On 17/03/2016 02:44, Peng Fan wrote: > On Wed, Mar 16, 2016 at 09:48:24AM -0300, Fabio Estevam wrote: >> Hi Peng, >> >> On Tue, Mar 15, 2016 at 10:27 PM, Peng Fan wrote: >> >>> If set the SION bit, we need to change the pinmux settings in device tree, >>> however

Re: [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value

2016-03-18 Thread Fabio Estevam
Hi Peng, On Tue, Mar 15, 2016 at 10:27 PM, Peng Fan wrote: > If set the SION bit, we need to change the pinmux settings in device tree, > however device tree are introduced from linux kernel. I would not like > to change the pinmux setting value. > > So I choose to use

Re: [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value

2016-03-18 Thread Peng Fan
On Wed, Mar 16, 2016 at 09:48:24AM -0300, Fabio Estevam wrote: >Hi Peng, > >On Tue, Mar 15, 2016 at 10:27 PM, Peng Fan wrote: > >> If set the SION bit, we need to change the pinmux settings in device tree, >> however device tree are introduced from linux kernel. I would not

Re: [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value

2016-03-15 Thread Peng Fan
Hi Fabio, On Tue, Mar 15, 2016 at 09:53:15AM -0300, Fabio Estevam wrote: >On Tue, Mar 15, 2016 at 2:48 AM, Peng Fan wrote: >> When configured a gpio to output direction, directly reading PSR register >> can not return the output value, since we did not set SION bit for

Re: [U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value

2016-03-15 Thread Fabio Estevam
On Tue, Mar 15, 2016 at 2:48 AM, Peng Fan wrote: > When configured a gpio to output direction, directly reading PSR register > can not return the output value, since we did not set SION bit for gpio > iomux. So, we can use data register to reflect what value is outputed.

[U-Boot] [PATCH 1/2] dm: gpio: mxc: fix mxc_gpio_bank_get_value

2016-03-14 Thread Peng Fan
When configured a gpio to output direction, directly reading PSR register can not return the output value, since we did not set SION bit for gpio iomux. So, we can use data register to reflect what value is outputed. If not, "regulator status" always return disabled, even if already "regulator