Re: [U-Boot] [PATCH 1/2] tegra: init MMC from common board init

2012-08-07 Thread Stephen Warren
On 08/06/2012 07:18 PM, Lucas Stach wrote:

There's no description here justifying why you want this change.

I don't think the change is correct; in arch/arm/lib/board.c,
board_init_r() calls drivers/mmc/mmc.c:mmc_initialize() which calls
board_mmc_init(). With this patch, won't this function get called twice?

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 1/2] tegra: init MMC from common board init

2012-08-07 Thread Lucas Stach
Am Dienstag, den 07.08.2012, 11:04 -0600 schrieb Stephen Warren:
 On 08/06/2012 07:18 PM, Lucas Stach wrote:
 
 There's no description here justifying why you want this change.
 
 I don't think the change is correct; in arch/arm/lib/board.c,
 board_init_r() calls drivers/mmc/mmc.c:mmc_initialize() which calls
 board_mmc_init(). With this patch, won't this function get called twice?
 
Please disregard this patch. It was only needed because of an error on
my side.

Sorry for the inconvenience.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 1/2] tegra: init MMC from common board init

2012-08-06 Thread Lucas Stach
Signed-off-by: Lucas Stach d...@lynxeye.de
CC: Stephen Warren swar...@wwwdotorg.org
CC: Tom Warren twar...@nvidia.com
---
 board/nvidia/common/board.c | 4 
 1 Datei geändert, 4 Zeilen hinzugefügt(+)

diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c
index 7ab2040..3bd4ff1 100644
--- a/board/nvidia/common/board.c
+++ b/board/nvidia/common/board.c
@@ -132,6 +132,10 @@ int board_init(void)
board_usb_init(gd-fdt_blob);
 #endif
 
+#ifdef CONFIG_TEGRA_MMC
+   board_mmc_init(gd-fdt_blob);
+#endif
+
 #ifdef CONFIG_TEGRA20_LP0
/* save Sdram params to PMC 2, 4, and 24 for WB0 */
warmboot_save_sdram_params();
-- 
1.7.11.2

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot