Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-28 Thread Marek Vasut
On 5/28/19 1:19 PM, Tom Rini wrote: > On Tue, May 28, 2019 at 05:24:34AM +0200, Marek Vasut wrote: >> On 5/28/19 5:04 AM, Tom Rini wrote: >>> On Tue, May 28, 2019 at 04:44:52AM +0200, Marek Vasut wrote: On 5/28/19 4:42 AM, Tom Rini wrote: > On Tue, May 28, 2019 at 04:07:44AM +0200, Marek

Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-28 Thread J. William Campbell
On 5/28/2019 4:19 AM, Tom Rini wrote: On Tue, May 28, 2019 at 05:24:34AM +0200, Marek Vasut wrote: On 5/28/19 5:04 AM, Tom Rini wrote: On Tue, May 28, 2019 at 04:44:52AM +0200, Marek Vasut wrote: On 5/28/19 4:42 AM, Tom Rini wrote: On Tue, May 28, 2019 at 04:07:44AM +0200, Marek Vasut wrote:

Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-28 Thread Tom Rini
On Tue, May 28, 2019 at 05:24:34AM +0200, Marek Vasut wrote: > On 5/28/19 5:04 AM, Tom Rini wrote: > > On Tue, May 28, 2019 at 04:44:52AM +0200, Marek Vasut wrote: > >> On 5/28/19 4:42 AM, Tom Rini wrote: > >>> On Tue, May 28, 2019 at 04:07:44AM +0200, Marek Vasut wrote: > On 5/28/19 4:06 AM,

Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-27 Thread Marek Vasut
On 5/28/19 5:04 AM, Tom Rini wrote: > On Tue, May 28, 2019 at 04:44:52AM +0200, Marek Vasut wrote: >> On 5/28/19 4:42 AM, Tom Rini wrote: >>> On Tue, May 28, 2019 at 04:07:44AM +0200, Marek Vasut wrote: On 5/28/19 4:06 AM, Tom Rini wrote: > On Tue, May 28, 2019 at 03:49:13AM +0200, Marek

Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-27 Thread Tom Rini
On Tue, May 28, 2019 at 04:44:52AM +0200, Marek Vasut wrote: > On 5/28/19 4:42 AM, Tom Rini wrote: > > On Tue, May 28, 2019 at 04:07:44AM +0200, Marek Vasut wrote: > >> On 5/28/19 4:06 AM, Tom Rini wrote: > >>> On Tue, May 28, 2019 at 03:49:13AM +0200, Marek Vasut wrote: > >>> > If the source

Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-27 Thread Marek Vasut
On 5/28/19 4:42 AM, Tom Rini wrote: > On Tue, May 28, 2019 at 04:07:44AM +0200, Marek Vasut wrote: >> On 5/28/19 4:06 AM, Tom Rini wrote: >>> On Tue, May 28, 2019 at 03:49:13AM +0200, Marek Vasut wrote: >>> If the source and destination buffer address is identical, there is no need to

Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-27 Thread Tom Rini
On Tue, May 28, 2019 at 04:07:44AM +0200, Marek Vasut wrote: > On 5/28/19 4:06 AM, Tom Rini wrote: > > On Tue, May 28, 2019 at 03:49:13AM +0200, Marek Vasut wrote: > > > >> If the source and destination buffer address is identical, there is > >> no need to memcpy() the content. Skip the memcpy()

Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-27 Thread Marek Vasut
On 5/28/19 4:06 AM, Tom Rini wrote: > On Tue, May 28, 2019 at 03:49:13AM +0200, Marek Vasut wrote: > >> If the source and destination buffer address is identical, there is >> no need to memcpy() the content. Skip the memcpy() in such a case. >> >> Signed-off-by: Marek Vasut >> Cc: Michal Simek

Re: [U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-27 Thread Tom Rini
On Tue, May 28, 2019 at 03:49:13AM +0200, Marek Vasut wrote: > If the source and destination buffer address is identical, there is > no need to memcpy() the content. Skip the memcpy() in such a case. > > Signed-off-by: Marek Vasut > Cc: Michal Simek > Cc: Tom Rini Shouldn't memcpy catch that

[U-Boot] [PATCH 1/3] spl: ram: Do not memcpy() identical buffers

2019-05-27 Thread Marek Vasut
If the source and destination buffer address is identical, there is no need to memcpy() the content. Skip the memcpy() in such a case. Signed-off-by: Marek Vasut Cc: Michal Simek Cc: Tom Rini --- common/spl/spl_ram.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git