Re: [U-Boot] [PATCH 1/3] wandboard: Replace is_cpu_type() for macro

[Stefano Babic]

On 22/07/2016 14:11, Breno Lima wrote:
> It's not necessary to use the is_cpu_type function, there is a macro in
> sys_proto.h already implemented.
> 
> Signed-off-by: Breno Lima 
> ---
>  board/wandboard/wandboard.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
> index 8340dd1..d7c1142 100644
> --- a/board/wandboard/wandboard.c
> +++ b/board/wandboard/wandboard.c
> @@ -390,7 +390,7 @@ int board_late_init(void)
>  #endif
>  
>  #ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
> - if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D))
> + if (is_mx6dq())
>   setenv("board_rev", "MX6Q");
>   else
>   setenv("board_rev", "MX6DL");
> @@ -409,7 +409,7 @@ int board_init(void)
>   gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
>  
>   setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, _i2c2_pad_info);
> - if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D))
> + if (is_mx6dq())
>   setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, _i2c2_pad_info);
>   else
>   setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, _i2c2_pad_info);
> 
Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] wandboard: Replace is_cpu_type() for macro

[Fabio Estevam]

On Fri, Jul 22, 2016 at 9:11 AM, Breno Lima  wrote:
> It's not necessary to use the is_cpu_type function, there is a macro in
> sys_proto.h already implemented.
>
> Signed-off-by: Breno Lima 

Reviewed-by: Fabio Estevam 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 1/3] wandboard: Replace is_cpu_type() for macro

[Breno Lima]

It's not necessary to use the is_cpu_type function, there is a macro in
sys_proto.h already implemented.

Signed-off-by: Breno Lima 
---
 board/wandboard/wandboard.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 8340dd1..d7c1142 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -390,7 +390,7 @@ int board_late_init(void)
 #endif
 
 #ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
-   if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D))
+   if (is_mx6dq())
setenv("board_rev", "MX6Q");
else
setenv("board_rev", "MX6DL");
@@ -409,7 +409,7 @@ int board_init(void)
gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
 
setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, _i2c2_pad_info);
-   if (is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D))
+   if (is_mx6dq())
setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, _i2c2_pad_info);
else
setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, _i2c2_pad_info);
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot