Re: [U-Boot] [PATCH 1/7] Add support for MX35 processor

2011-01-21 Thread Detlev Zundel
Hi Wolfgang, What do these ! markers mean? They have no useful meaning and I must drop them. There are other such cryptic markers - eventually from some doc generating tool. Correct - I'm pretty sure this was intended for doxygen. Cheers Detlev -- Some people seem to think that C is

Re: [U-Boot] [PATCH 1/7] Add support for MX35 processor

2011-01-19 Thread Stefano Babic
On 01/19/2011 08:35 AM, Wolfgang Denk wrote: Dear Stefano Babic, +if (!reg) { +reg = __REG(ROMPATCH_REV); __REG()? It should not be.. NAK. Please use I/O accessors. Please fix globally. I supposed to have already replaced all of them, but I have missed some of them.

Re: [U-Boot] [PATCH 1/7] Add support for MX35 processor

2011-01-19 Thread Wolfgang Denk
Dear Stefano Babic, In message 4d36b2af.9000...@denx.de you wrote: +void imx_get_mac_from_fuse(unsigned char *mac) +{ + int i; + + for (i = 0; i 6; i++) + mac[i] = 0; memset(mac, 0, 6); ? I think your question mark is related to the fact that it is not so

Re: [U-Boot] [PATCH 1/7] Add support for MX35 processor

2011-01-19 Thread Stefano Babic
On 01/19/2011 12:37 PM, Wolfgang Denk wrote: No, I wonder why code a loop when a simple memset() does the same. Ok, I get the point - you are right, I will replace the code with memset. What do these ! markers mean? They have no useful meaning and I must drop them. There are other such

Re: [U-Boot] [PATCH 1/7] Add support for MX35 processor

2011-01-18 Thread Wolfgang Denk
Dear Stefano Babic, In message 1295012124-15551-1-git-send-email-sba...@denx.de you wrote: The patch adds basic support for the Freescale's i.MX35 (arm1136 based) processor. Signed-off-by: Stefano Babic sba...@denx.de ... +u32 get_cpu_rev(void) +{ + int reg; + struct iim_regs