Re: [U-Boot] [PATCH 1/9] SOUND: Add I2S driver

Hi, On Sat, Aug 18, 2012 at 12:23 AM, Mike Frysinger vap...@gentoo.org wrote: On Friday 17 August 2012 08:48:59 Andrew Dyer wrote: The code in the i2s.c file is still full of samsung soc specific stuff, so I think the filename is misleading. Something like samsung-i2s.c would be more

Re: [U-Boot] [PATCH 1/9] SOUND: Add I2S driver

Hi Andrew, Thank you for comments. On Thu, Aug 16, 2012 at 8:29 PM, Andrew Dyer amd...@gmail.com wrote: I don't have any comment on the body of the patch, but calling this an i2s patch is misleading. I2s is a generic standard for moving stereo audio around, and many chips support it. This

Re: [U-Boot] [PATCH 1/9] SOUND: Add I2S driver

The code in the i2s.c file is still full of samsung soc specific stuff, so I think the filename is misleading. Something like samsung-i2s.c would be more appropriate. On Aug 17, 2012 1:44 AM, Rajeshwari Birje rajeshwari.bi...@gmail.com wrote: Hi Andrew, Thank you for comments. On Thu, Aug

Re: [U-Boot] [PATCH 1/9] SOUND: Add I2S driver

On Friday 17 August 2012 08:48:59 Andrew Dyer wrote: The code in the i2s.c file is still full of samsung soc specific stuff, so I think the filename is misleading. Something like samsung-i2s.c would be more appropriate. +1 -mike signature.asc Description: This is a digitally signed message

Re: [U-Boot] [PATCH 1/9] SOUND: Add I2S driver

I don't have any comment on the body of the patch, but calling this an i2s patch is misleading. I2s is a generic standard for moving stereo audio around, and many chips support it. This patch looks like i2s support for a specific codec chip and the filenames should reflect that.

[U-Boot] [PATCH 1/9] SOUND: Add I2S driver

This patch adds driver for I2S interface Signed-off-by: R. Chandrasekar rcse...@samsung.com Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com --- Makefile |1 + drivers/sound/Makefile | 47 +++ drivers/sound/i2s.c| 358