Re: [U-Boot] [PATCH 12/35] arm: socfpga: clock: Implant order into bit definitions

2014-09-16 Thread Marek Vasut
On Tuesday, September 16, 2014 at 10:18:32 AM, Wolfgang Denk wrote: > Dear Marek, > > In message <201409152348.15411.ma...@denx.de> you wrote: > > > cm_write_bypass( > > > > > > CLKMGR_BYPASS_PERPLLSRC_SET( > > > CLKMGR_BYPASS_PERPLLSRC_SELECT_EOSC1

Re: [U-Boot] [PATCH 12/35] arm: socfpga: clock: Implant order into bit definitions

2014-09-16 Thread Wolfgang Denk
Dear Marek, In message <201409152348.15411.ma...@denx.de> you wrote: > > > cm_write_bypass( > > CLKMGR_BYPASS_PERPLLSRC_SET( > > CLKMGR_BYPASS_PERPLLSRC_SELECT_EOSC1) | > > CLKMGR_BYPASS_SDRPLLSRC_SET( > > CLKMGR_BYPASS_SDRPLL

Re: [U-Boot] [PATCH 12/35] arm: socfpga: clock: Implant order into bit definitions

2014-09-15 Thread Marek Vasut
On Monday, September 15, 2014 at 11:21:22 PM, Pavel Machek wrote: > Hi! > > > Dear Marek Vasut, > > > > In message <1410779188-6880-13-git-send-email-ma...@denx.de> you wrote: > > > The bit definitions for clock manager are complete chaos. Implement > > > some basic logical order into them. > >

Re: [U-Boot] [PATCH 12/35] arm: socfpga: clock: Implant order into bit definitions

2014-09-15 Thread Pavel Machek
Hi! > Dear Marek Vasut, > In message <1410779188-6880-13-git-send-email-ma...@denx.de> you wrote: > > The bit definitions for clock manager are complete chaos. Implement > > some basic logical order into them. > ... > > +#define CLKMGR_BYPASS_MAINPLL_SET(x) (((x) << 0) & > > 0x0

Re: [U-Boot] [PATCH 12/35] arm: socfpga: clock: Implant order into bit definitions

2014-09-15 Thread Wolfgang Denk
Dear Marek Vasut, In message <1410779188-6880-13-git-send-email-ma...@denx.de> you wrote: > The bit definitions for clock manager are complete chaos. Implement > some basic logical order into them. ... > +#define CLKMGR_BYPASS_MAINPLL_SET(x) (((x) << 0) & 0x0001) > +#define CLKMGR_BYPA

[U-Boot] [PATCH 12/35] arm: socfpga: clock: Implant order into bit definitions

2014-09-15 Thread Marek Vasut
The bit definitions for clock manager are complete chaos. Implement some basic logical order into them. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dinh Nguyen Cc: Albert Aribaud Cc: Tom Rini Cc: Wolfgang Denk Cc: Pavel Machek --- arch/arm/include/asm/arch-socfpga/clock_manager.h | 1