Re: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x

2013-01-10 Thread Tom Rini
On Thu, Jan 10, 2013 at 08:30:09AM +0100, Lars Poeschel wrote: Hi Wolfgang, hi Tom, as I almost have the changes requested by Wolfgang in place, you two can choose, which version I should resubmit. ;) Am 09.01.2013 um 20:34 schrieb Tom Rini: [snip] + if (!eth_getenv_enetaddr(ethaddr,

Re: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x

2013-01-09 Thread Lars Poeschel
Hello Wolfgang, thank you for your fast review! On Tuesday 08 January 2013 at 19:58:37, Wolfgang Denk wrote: +/* DDR RAM defines */ +#define DDR_CLK_MHZ303 Is this really correct? 303 ?? I am quite sure, I read this in a datasheet, but I can not find it anymore. I set

Re: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x

2013-01-09 Thread Tom Rini
On Tue, Jan 08, 2013 at 07:58:37PM +0100, Wolfgang Denk wrote: Dear Lars, In message 1357663926-15937-2-git-send-email-la...@wh2.tu-dresden.de you wrote: ... arch/arm/include/asm/arch-am33xx/ddr_defs.h | 18 ++ board/phytec/pcm051/Makefile| 46

Re: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x

2013-01-09 Thread Lars Poeschel
Hi Wolfgang, hi Tom, as I almost have the changes requested by Wolfgang in place, you two can choose, which version I should resubmit. ;) Am 09.01.2013 um 20:34 schrieb Tom Rini: +static void rtc32k_enable(void) +{ + struct rtc_regs *rtc = (struct rtc_regs *)AM335X_RTC_BASE; + + /* +

[U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x

2013-01-08 Thread Lars Poeschel
From: Lars Poeschel poesc...@lemonage.de The board is named pcm051 and has this hardware: SOC: TI AM3359 DDR3-RAM: 2x MT41J256M8HX-15EIT:D 512MiB ETH 1: LAN8710AI SPI-Flash: W25Q64BVSSIG RTC: RV-4162-C7 I2C-EEPROM: CAT32WC32 NAND: MT29F4G08_VFPGA63 PMIC: TPS65910A3 LCD Supported: UART 1 MMC/SD

Re: [U-Boot] [PATCH 2/2] pcm051: Add support for Phytec phyCORE-AM335x

2013-01-08 Thread Wolfgang Denk
Dear Lars, In message 1357663926-15937-2-git-send-email-la...@wh2.tu-dresden.de you wrote: ... arch/arm/include/asm/arch-am33xx/ddr_defs.h | 18 ++ board/phytec/pcm051/Makefile| 46 board/phytec/pcm051/board.c | 271 +++